Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MeshShape::clear() for safer mesh removal (backport #3164) #3167

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 16, 2024

Description

To address #3162 (comment), I add a check to retrieve the mesh by name before attempting to remove it.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3164 done by [Mergify](https://mergify.com).

Added a check to retrieve the mesh by name before attempting to remove it.

(cherry picked from commit f91a650)
@sea-bass sea-bass merged commit ccc75f1 into jazzy Dec 16, 2024
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3164 branch December 16, 2024 14:51
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.06%. Comparing base (e94c891) to head (8fb3bbc).
Report is 1 commits behind head on jazzy.

Files with missing lines Patch % Lines
...zation/rviz_plugin_render_tools/src/mesh_shape.cpp 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3167      +/-   ##
==========================================
- Coverage   44.07%   44.06%   -0.00%     
==========================================
  Files         698      698              
  Lines       61535    61539       +4     
  Branches     7457     7458       +1     
==========================================
- Hits        27115    27113       -2     
- Misses      34252    34258       +6     
  Partials      168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants