Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the non-deprecated service fields for switching controllers #2927

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

saikishor
Copy link

@saikishor saikishor commented Jul 24, 2024

Description

Hello!

This PR aims to start using the non-deprecated fields of the ros2_control service to switch the controllers. If the changes look good, can this be merged and tagged as well?. It's just there is no release of MoveIt2 in Humble since September 2023. Thank you

@sjahr
Copy link
Contributor

sjahr commented Jul 24, 2024

@saikishor Thanks for the PR! Is that deprecation specific to humble? If not, please target main and we backport this PR automatically

@saikishor
Copy link
Author

@saikishor Thanks for the PR! Is that deprecation specific to humble? If not, please target main and we backport this PR automatically

Hello @sjahr!

Thank you for your very rapid response. The main branch already has the changes. That's why I opened them for Humble. For instance, below are the changes in the main corresponding to the same file

{ // resource is claimed
if (std::find(request->deactivate_controllers.begin(), request->deactivate_controllers.end(),
res->second) == request->deactivate_controllers.end())
{
request->deactivate_controllers.push_back(res->second); // add claiming controller to stop list
}
claimed_resources.left.erase(res->second); // remove claimed resources

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

@saikishor
Copy link
Author

Once this is merged! Can you consider releasing it as well?

@sjahr sjahr merged commit 25f22ce into moveit:humble Jul 25, 2024
4 checks passed
@saikishor
Copy link
Author

hello @sjahr !

Is there any plan to tag and release Humble branch soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants