-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: RobotTrajectory append() (backport #1813) #1821
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## humble #1821 +/- ##
==========================================
+ Coverage 50.93% 50.95% +0.02%
==========================================
Files 381 382 +1
Lines 31884 31895 +11
==========================================
+ Hits 16238 16248 +10
- Misses 15646 15647 +1
☔ View full report in Codecov by Sentry. |
@AndyZe any idea what's wrong with the tests? |
* Add a test for append() * Don't add to the timestep, rather overwrite it (cherry picked from commit 35bb662)
fe6d3c7
to
70af628
Compare
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
I just found that this PR not being backported because of the stale bot closing it caused a fix to the Pilz sequencing (#2961) (which was backported) to regress on Humble. See #3161 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## humble #1821 +/- ##
==========================================
- Coverage 51.25% 51.25% -0.00%
==========================================
Files 382 382
Lines 31885 31885
==========================================
- Hits 16341 16340 -1
- Misses 15544 15545 +1 ☔ View full report in Codecov by Sentry. |
This is an automatic backport of pull request #1813 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com