Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm unnessary time offset in pilz #3169

Closed

Conversation

wuisky
Copy link

@wuisky wuisky commented Dec 17, 2024

Description

A workaround of #3161

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I get it!

My deduplication fix in the last PR is looking for points that are identical, but in your case they are identical but actually at non-equal times.

Small comment, but I will also test these fixes on Rolling to see if the original issue they intended to fix is still good with these changes.

@sea-bass sea-bass mentioned this pull request Dec 17, 2024
6 tasks
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.04%. Comparing base (f91a650) to head (27cdc4f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ial_motion_planner/src/plan_components_builder.cpp 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3169      +/-   ##
==========================================
- Coverage   44.07%   44.04%   -0.03%     
==========================================
  Files         698      698              
  Lines       61541    61542       +1     
  Branches     7458     7459       +1     
==========================================
- Hits        27117    27097      -20     
- Misses      34256    34277      +21     
  Partials      168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants