Hercules Inpulse 200: document new Shift-browser turn scrolls list #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
reviewed
Mar 7, 2024
| @@ -68,8 +68,9 @@ Browser | |||
| Control Function | |||
| =============================================================== ========================================== | |||
| :hwlabel:`BROWSER` encoder (turn) Move up/down list. | |||
| :hwlabel:`SHIFT` + :hwlabel:`BROWSER` encoder (turn) Scroll up/down list. | |||
There was a problem hiding this comment.
Thank you.
We have unnecessary linebreaks here because of (IMO unnecessary) "encoder".
Do you mind removing it so we only have "BROWSER turn" and "BROWSER press"?
ronso0
changed the title
ronso0
reviewed
Mar 8, 2024
| :hwlabel:`BROWSER` turn Move up/down list. | ||
| :hwlabel:`SHIFT` + :hwlabel:`BROWSER` turn Scroll up/down list. | ||
| :hwlabel:`BROWSER` press Switch focus between list and file view. | ||
| :hwlabel:`SHIFT` + :hwlabel:`BROWSER` press Maximize/Minimize library view. | ||
| :hwlabel:`ASSISTANT` button Toggle AutoDJ (be sure a playlist was created for AutoDJ before activating this function). |
There was a problem hiding this comment.
Ah, okay, the lines in the left column are broken because of the long text in the second column.
This hint is not required IMO, but maybe it's obsessive to insist on a compact table here. Up to you 🤷
Suggested change
| :hwlabel:`ASSISTANT` button Toggle AutoDJ (be sure a playlist was created for AutoDJ before activating this function). | |
| :hwlabel:`ASSISTANT` button Toggle AutoDJ |
There was a problem hiding this comment.
I want to fix it too! I tried to shorten it because I've been puzzled myself by the autodj not working with an empty playlist.
|
Thank you, looking good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update according to mixxxdj/mixxx#12932