Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hercules Inpulse 200 - Configure shift-browser knob to scroll the library (quick) #12932

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

nlw0
Copy link

@nlw0 nlw0 commented Mar 7, 2024

Shift-browser knob is currently unassigned. This assigns it to scroll the library (page up/down) instead of just moving the cursor, so you can move more quickly in a large library.

@nlw0 nlw0 changed the title Configure shift-browser knob to scroll the library (quick) Hercules Inpulse 200 - Configure shift-browser knob to scroll the library (quick) Mar 7, 2024
@ronso0 ronso0 changed the base branch from main to 2.4 March 7, 2024 09:22
@ronso0
Copy link
Member

ronso0 commented Mar 7, 2024

Thank you for this PR, code LGTM!
Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

Mapping changes go to the current stable branch (2.4), I've changed the base branch here accordingly. Please rebase your local branch and force-push.

Please also update the manual page https://github.com/mixxxdj/manual/blob/2.4/source/hardware/controllers/hercules_djcontrol_inpulse_200.rst

@nlw0
Copy link
Author

nlw0 commented Mar 7, 2024

All right. I rebased this PR and created one for the documentation mixxxdj/manual#626

@ronso0
Copy link
Member

ronso0 commented Mar 8, 2024

just waiting for the manual PR, if you like to polish it (AutoDJ hint) I'll merge afterwards. If not let me know.

@ronso0
Copy link
Member

ronso0 commented Mar 8, 2024

Thanks!

@ronso0 ronso0 merged commit 474b82a into mixxxdj:2.4 Mar 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants