Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hercules Inpulse 200: document new Shift-browser turn scrolls list #626

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Hercules Inpulse 200: document new Shift-browser turn scrolls list #626

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c692e7
Shift-browser turn scrolls list
Mar 7, 2024
3ab4215
removing 'encoder' from browser info
Mar 7, 2024
2b6f89f
shorter autodj playlist advice
Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion source/hardware/controllers/hercules_djcontrol_inpulse_200.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ Browser
Control Function
=============================================================== ==========================================
:hwlabel:`BROWSER` encoder (turn) Move up/down list.
:hwlabel:`SHIFT` + :hwlabel:`BROWSER` encoder (turn) Scroll up/down list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
We have unnecessary linebreaks here because of (IMO unnecessary) "encoder".
Do you mind removing it so we only have "BROWSER turn" and "BROWSER press"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, I thought the same

:hwlabel:`BROWSER` encoder (press) Switch focus between list and file view.
:hwlabel:`SHIFT` + Encoder (press) Maximize/Minimize library view.
:hwlabel:`SHIFT` + :hwlabel:`BROWSER` encoder (press) Maximize/Minimize library view.
:hwlabel:`ASSISTANT` button Toggle AutoDJ (be sure a playlist was created for AutoDJ before activating this function).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay, the lines in the left column are broken because of the long text in the second column.

This hint is not required IMO, but maybe it's obsessive to insist on a compact table here. Up to you 🤷

Suggested change
:hwlabel:`ASSISTANT` button Toggle AutoDJ (be sure a playlist was created for AutoDJ before activating this function).
:hwlabel:`ASSISTANT` button Toggle AutoDJ

Copy link
Author

@nlw0 nlw0 Mar 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to fix it too! I tried to shorten it because I've been puzzled myself by the autodj not working with an empty playlist.

=============================================================== ==========================================

Expand Down
Loading