Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outputs and adjust split size #7

Open
wants to merge 2 commits into
base: img
Choose a base branch
from
Open

Add outputs and adjust split size #7

wants to merge 2 commits into from

Conversation

scanon
Copy link
Contributor

@scanon scanon commented Nov 22, 2021

This adds several missing outputs from the structural annotation portion
of the pipeline (crt, genemark, prodigal, trnascan, rfam). These
outputs were being used in the full outputs but the individual GFF files
weren't being propagated as outputs.

This also adjusts the split size to 100M. Testing found that the memory
requirements and run-times are still pretty reasonable at this split
size. This significantly improves throughput since most of the steps
run in the same amount of time for the larger split size.

This adds several missing outputs from the structural annotation portion
of the pipeline (crt, genemark, prodigal, trnascan, rfam).  These
outputs were being used in the full outputs but the individual GFF files
weren't being propagated as outputs.

This also adjusts the split size to 100M.  Testing found that the memory
requirements and run-times are still pretty reasonable at this split
size.  This significantly improves throughput since most of the steps
run in the same amount of time for the larger split size.
@aclum
Copy link
Collaborator

aclum commented Jun 11, 2024

@scanon okay if I close this PR as obsolete? The block size of 100 is already in the master branch and reconciling missing output files was addressed in December 2022.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants