-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader writer fixes #60
Conversation
…iter, update tests
… the parent directory
@ieivanov do you think you can take a quick look here so we can merge? I have implemented and tested all of your suggestions (thanks!) |
I can use this branch to load data well. When writing, I faced some issues in the specification of Here is the code block that I use to write the uPTI data.
I did not encounter an issue using the previous version of the writer. When running this code with this branch, I encounter the following error:
It seems to mean that we need to specify With these tests, there are a few questions to be answered:
I do like the part of this version that uses "FFFFFF" as the default colormap. It visualizes images with a brighter contrast to start with. |
Thanks for catching this @lihaoyeh. We want their to be default clims if the user doesn't specify any. It seems like there is a slight bug and I will fix it. |
@lihaoyeh I also added the catch for the numpy datatypes that aren't serializable and now the clims will automatically be converted to regular floats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this new version and it works for my test case. I have resolved the conflicts and merged the master into this branch. Please go ahead and merge it to the master.
This PR fixes a lot of the issues that @ieivanov brought up on the issue page.
Specifically:
Writer:
arr_0
instead ofarray
[0,N]
as a range for writing data and instead implements pythonicslice(0, N)
Reader:
data_type
is not explicitly provided by the userarray
name and alsoarr_0
Other:
background_estimator
to np.float64 in order to avoid numpy deprecation