Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaveorderWriter default array name #57

Closed
ieivanov opened this issue Jan 3, 2022 · 2 comments
Closed

WaveorderWriter default array name #57

ieivanov opened this issue Jan 3, 2022 · 2 comments
Assignees
@camFoltz

Comments

@ieivanov
Copy link
Contributor

ieivanov commented Jan 3, 2022

Zarr defaults to calling an unnamed array arr_0, maybe we can call the array that the WaveorderWriter writes arr_0 instead of array. This way we can use the dot notation to index the array: zs.arr_0 instead of zs['arr_0']. @camFoltz if you remember zs.array is a method that we're overloading by calling the data array array
@camFoltz
Copy link
Contributor

camFoltz commented Jan 5, 2022

Ah yes, I am perfectly happy with that nomenclature. I can make this change with the others.

@camFoltz camFoltz self-assigned this Jan 5, 2022
@camFoltz
Copy link
Contributor

camFoltz commented Jan 7, 2022

fixed in #60

@camFoltz camFoltz closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camFoltz camFoltz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ieivanov @camFoltz