Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaveorderReader should try to guess data_type and make that an optional argument #53

Closed
ieivanov opened this issue Dec 28, 2021 · 3 comments
Assignees

Comments

@ieivanov
Copy link
Contributor

No description provided.

@camFoltz
Copy link
Contributor

camFoltz commented Jan 5, 2022

Yeah I have had this idea for a while, it will be easy enough to do this for OME-zarr datasets (quick metadata check + looking for the .zarr ending.

Multipage vs. single-page tiff may have some easily accessible information in the header to distinguish, but if not we could just look to see if the file contains multiple pages, or not. This latter strategy might mess with how we read the metadata however, as one can technically save a single snapshot as multi-page tiff (metadata embedded in the file) versus single snapshot as single-page tiff (metadata exists in external file). I'll look into this a bit but I do not think it would be difficult to implement.

@camFoltz camFoltz self-assigned this Jan 5, 2022
@ieivanov
Copy link
Contributor Author

ieivanov commented Jan 5, 2022

That would be great, thanks. I think a defining feature of zarr datasets is the .zgroup file, not so much the .zarr extension, I've run into problems with forgetting to add .zarr to the dataset name before.

I believe Bryant did some work to properly parse tif files, but I'm not sure where that lives

@camFoltz
Copy link
Contributor

camFoltz commented Jan 7, 2022

fixed in #60

@camFoltz camFoltz closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants