Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow specification of now --public in .drone.yml #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: Allow specification of now --public in .drone.yml #2

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d224fa
feat: Allow `public` option in .drone.yml
atomdmac Mar 23, 2018
a57c8ca
chore: Update README.md
atomdmac Mar 23, 2018
4eda259
chore: Update DOC.md to include `public` setting.
atomdmac Mar 23, 2018
dfcb8ab
chore: Improve console output for `public` option.
atomdmac Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,5 @@ pipeline:
directory: public
alias: my.deployment.com
secrets: [ now_token ]
public: true
```
9 changes: 9 additions & 0 deletions script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ set -e
NOW_DEPLOY_OPTIONS=" --no-clipboard"
NOW_AUTH=""

# Is this a public deployment?
if [ "$PLUGIN_PUBLIC" == "true" ]
then
echo "> adding option --public"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be more precise ?
The documentation of the API can help.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of precision are you looking for here? It seems obvious enough to me that the option corresponds to the now CLI given that this is a Drone plugin for precisely that. I'm happy to modify but I'm not clear on what other information you'd like to include here.

Copy link
Owner

@lucaperret lucaperret Mar 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For every deployment done under the OSS plan, this needs to be set to true.

It could be good to inform the user that if he has a OSS plan, his source code and logs will be public, for example.

NOW_DEPLOY_OPTIONS="${NOW_DEPLOY_OPTIONS} --public"
else
echo "> --public option not specified"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precise the default value.

fi

# Get the token or error
if [ -z "$PLUGIN_NOW_TOKEN" ]
then
Expand Down