feat: Allow specification of now --public in .drone.yml #2
Conversation
script.sh
Outdated
| # Is this a public deployment? | ||
| if [ "$PLUGIN_PUBLIC" == "true" ] | ||
| then | ||
| echo "> adding option --public" |
There was a problem hiding this comment.
Could you be more precise ?
The documentation of the API can help.
There was a problem hiding this comment.
What kind of precision are you looking for here? It seems obvious enough to me that the option corresponds to the now CLI given that this is a Drone plugin for precisely that. I'm happy to modify but I'm not clear on what other information you'd like to include here.
There was a problem hiding this comment.
For every deployment done under the OSS plan, this needs to be set to true.
It could be good to inform the user that if he has a OSS plan, his source code and logs will be public, for example.
script.sh
Outdated
| echo "> adding option --public" | ||
| NOW_DEPLOY_OPTIONS="${NOW_DEPLOY_OPTIONS} --public" | ||
| else | ||
| echo "> --public option not specified" |
| # Is this a public deployment? | ||
| if [ "$PLUGIN_PUBLIC" == "true" ] | ||
| then | ||
| echo "> adding option --public. If you are using an OSS plan, your source and logs will be public!" |
There was a problem hiding this comment.
That is not true. In any case with this public option, the source and logs will be public...
configuring public deployment. Your source and logs will be public!
| @@ -122,6 +122,17 @@ pipeline: | |||
| + scale: 2 | |||
| ``` | |||
|
|
|||
| Example configuration for specifying the `--public` argument for the `now` CLI. | |||
There was a problem hiding this comment.
Could you add this link for documentation : https://zeit.co/blog/now-public
| deploy_name: deployment-name | ||
| secrets: [ now_token ] | ||
| - scale: 2 | ||
| + public: true |
There was a problem hiding this comment.
Could you add this public property to the Parameter Reference section
|
Hi @atomdmac, your feature request is quite interessant, could you complete the changes ? |
Allows users of the Drone plugin to specify the
--publicoption as they would when using thenowCLI directory. To do this, simply add the option to the.drone.ymlfile: