-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow specification of now --public in .drone.yml #2
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,6 +122,17 @@ pipeline: | |
+ scale: 2 | ||
``` | ||
|
||
Example configuration for specifying the `--public` argument for the `now` CLI. | ||
|
||
```diff | ||
pipeline: | ||
now: | ||
image: lucap/drone-now | ||
deploy_name: deployment-name | ||
secrets: [ now_token ] | ||
- scale: 2 | ||
+ public: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add this |
||
``` | ||
|
||
# Secret Reference | ||
|
||
|
@@ -158,4 +169,4 @@ rules_file | |
: File that contain set of rules | ||
|
||
scale | ||
: Min and Max scaling values | ||
: Min and Max scaling values |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,4 +45,5 @@ pipeline: | |
directory: public | ||
alias: my.deployment.com | ||
secrets: [ now_token ] | ||
public: true | ||
``` |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,15 @@ set -e | |
NOW_DEPLOY_OPTIONS=" --no-clipboard" | ||
NOW_AUTH="" | ||
|
||
# Is this a public deployment? | ||
if [ "$PLUGIN_PUBLIC" == "true" ] | ||
then | ||
echo "> adding option --public. If you are using an OSS plan, your source and logs will be public!" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is not true. In any case with this
|
||
NOW_DEPLOY_OPTIONS="${NOW_DEPLOY_OPTIONS} --public" | ||
else | ||
echo "> --public option not specified." | ||
fi | ||
|
||
# Get the token or error | ||
if [ -z "$PLUGIN_NOW_TOKEN" ] | ||
then | ||
|
@@ -94,4 +103,4 @@ then | |
exit $rc | ||
else | ||
echo $'\n'"> Successfully deployed! $NOW_DEPLOYMENT_URL"$'\n' | ||
fi | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this link for documentation : https://zeit.co/blog/now-public