[MooreToCore] [3/4] Add support for lowering moore.class.upcast #9152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheremo
force-pushed
the
pr-moore-classes-upcastop-lowering
branch
from
800ef7e to
69a48d7
Compare
Scheremo
changed the title
Scheremo
force-pushed
the
pr-moore-classes-upcastop-lowering
branch
6 times, most recently
from
c5edc36 to
98ce8db
Compare
fabianschuiki
approved these changes
Oct 31, 2025
Scheremo
force-pushed
the
pr-moore-classes-upcastop-lowering
branch
3 times, most recently
from
5f24814 to
c6fbc04
Compare
- Added `ClassUpcastOpConversion` lowering:
- Converts `moore.class.upcast` to a direct value forward when both source and
destination are LLVM opaque pointers (`!llvm.ptr`).
- Emits a diagnostic if applied to non-opaque pointer types.
- Registered the new pattern in `populateOpConversion` alongside other class
conversion patterns.
Scheremo
force-pushed
the
pr-moore-classes-upcastop-lowering
branch
from
c6fbc04 to
dea68e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ClassUpcastOpConversionlowering:moore.class.upcastto a direct value forward when both source anddestination are LLVM opaque pointers (
!llvm.ptr).Registered the new pattern in
populateOpConversionalongside other classconversion patterns.