[MooreToCore] [2/4] Add support to lower ClassNewOp to llvm.malloc #9151
+146
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheremo
changed the title
Scheremo
changed the title
Scheremo
force-pushed
the
pr-moore-classes-newop-lowering
branch
2 times, most recently
from
ed1c6b4 to
2a6b8d1
Compare
Scheremo
changed the title
Scheremo
changed the title
Scheremo
force-pushed
the
pr-moore-classes-newop-lowering
branch
from
2a6b8d1 to
d673e07
Compare
Scheremo
changed the title
Scheremo
force-pushed
the
pr-moore-classes-newop-lowering
branch
2 times, most recently
from
f896394 to
c26734d
Compare
Scheremo
force-pushed
the
pr-moore-classes-newop-lowering
branch
6 times, most recently
from
d505495 to
9da5c15
Compare
fabianschuiki
approved these changes
Oct 31, 2025
Scheremo
force-pushed
the
pr-moore-classes-newop-lowering
branch
from
9da5c15 to
3f39b9e
Compare
- Add `getOrCreateMalloc` to declare `llvm.func @malloc(i64) -> !llvm.ptr` (opaque ptr). - Implement `ClassNewOpConversion`: - Resolve class struct body, compute size via `DataLayout`, call `malloc`. - Replace `moore.class.new` with result of `malloc` (no cast in opaque-ptr mode). - Make base-class struct resolution lazy: - If a base’s struct isn’t finalized, resolve it on demand. - Add overload `resolveClassStructBody(ModuleOp, SymbolRefAttr, ...)`. - Register new conversion pattern in `populateOpConversion`.
Scheremo
force-pushed
the
pr-moore-classes-newop-lowering
branch
from
9ebfa95 to
527e76d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getOrCreateMallocto declarellvm.func @malloc(i64) -> !llvm.ptr(opaque ptr).ClassNewOpConversion:DataLayout, callmalloc.moore.class.newwith result ofmalloc(no cast in opaque-ptr mode).resolveClassStructBody(ModuleOp, SymbolRefAttr, ...).populateOpConversion.