[circt-test] fix SymbiYosys integration test #7886
Open
+34
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
unlsycn
force-pushed
the
test-sby-fix
branch
from
a771274
to
ccfacf5
Compare
Signed-off-by: unlsycn <[email protected]>
|
https://github.com/llvm/circt/actions/runs/11998261862/job/33447711728#step:5:330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7756 adds the SymbiYosys test runner and requires the
sbyfeature, but did not add the corresponding available feature inlit.cfg.py, so this test never seems to run, and #7763 introduces a syntax error, a backslash in the f-string expression part, in the Python script.Unlike #7884, there is no need to modify PATH variable for the script since
sbyshould be in the PATH if we can check it in CMake.