Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Make IMDCE work for ops w/ regions/blocks #7881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FIRRTL] Make IMDCE work for ops w/ regions/blocks #7881

wants to merge 1 commit into from

Commits on Nov 23, 2024

  1. [FIRRTL] Make IMDCE work for ops w/ regions/blocks 

    Fix a bug in FIRRTL's IMDCE Pass where it would not visit the blocks of
operations.  This can result in crashes for blocks which contain users of
FIRRTL modules, e.g., instances inside layerblocks of sv.ifdef.

This conceptually is two changes: (1) when marking a block live, the block
needs to be recursively walked and (2) when erasing ops, a recursive walk
is needed.

Signed-off-by: Schuyler Eldridge <[email protected]>
    @seldridge
    seldridge committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    34ba163 View commit details
    Browse the repository at this point in the history