save

Author: uenoku

lib/Dialect/FIRRTL/Transforms/LowerAnnotations.cpp

@@ -298,13 +298,14 @@ applyConventionOrTypeLoweringAnno(const AnnoPathValue &target,
 
   auto conventionStrAttr =
       tryGetAs<StringAttr>(anno, anno, "convention", loc, conventionAnnoClass);
-
   if (!conventionStrAttr)
     return failure();
+
   auto conventionStr = conventionStrAttr.getValue();
   auto conventionOpt = parseConvention(conventionStr);
   if (!conventionOpt)
     return error() << "unknown convention " << conventionStr;
+
   auto convention = *conventionOpt;
 
   if (convention == Convention::Internal)

lib/Dialect/FIRRTL/Transforms/LowerLayers.cpp

@@ -209,8 +209,8 @@ FModuleOp LowerLayersPass::buildNewModule(OpBuilder &builder,
   llvm::sys::SmartScopedLock<true> instrumentationLock(*circuitMutex);
   FModuleOp newModule = builder.create<FModuleOp>(
       location, builder.getStringAttr(namehint),
-      ConventionAttr::get(builder.getContext(), Convention::Internal),
-      ports, ArrayAttr{});
+      ConventionAttr::get(builder.getContext(), Convention::Internal), ports,
+      ArrayAttr{});
   if (auto dir = getOutputFile(layerBlock.getLayerNameAttr())) {
     assert(dir.isDirectory());
     newModule->setAttr("output_file", dir);

lib/Dialect/FIRRTL/Transforms/LowerMemory.cpp

@@ -252,8 +252,7 @@ void LowerMemoryPass::lowerMemory(MemOp mem, const FirMemory &summary,
   OpBuilder b(mem->getParentOfType<FModuleOp>());
   auto wrapper = b.create<FModuleOp>(
       mem->getLoc(), wrapperName,
-      ConventionAttr::get(context, Convention::Internal),
-      ports);
+      ConventionAttr::get(context, Convention::Internal), ports);
   SymbolTable::setSymbolVisibility(wrapper, SymbolTable::Visibility::Private);
 
   // Create an instance of the external memory module. The instance has the