Skip to content

[EPIC] Triggerable Withdrawals (develop ⇒ master) #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 564 commits into from
Oct 13, 2025
Merged

[EPIC] Triggerable Withdrawals (develop ⇒ master) #1382

merged 564 commits into from
Oct 13, 2025

Conversation

tamtamchik
Copy link
Member

@tamtamchik tamtamchik commented Aug 18, 2025 •
edited
Loading

Amuhar and others added 30 commits May 30, 2025 10:56
@Amuhar
fix: _consumeLimit
a2dd3d4
@Amuhar
fix: refund test
4350459
@Amuhar
Merge pull request #1130 from lidofinance/feat/refund-test
5ae428c 
fix: refund test
@mkurayan
refactor: clean-up withdrawal vault
106a06d
@Amuhar
fix: MAX_VALIDATORS_PER_BATCH -> MAX_VALIDATORS_PER_REPORT
c2dda55
@Amuhar
fix: dont limit oracle by common veb limit
09f4697
@Amuhar
Merge pull request #1131 from lidofinance/fix/exclude-batch-from-name
5f2bfec 
MAX_VALIDATORS_PER_BATCH -> MAX_VALIDATORS_PER_REPORT
@Amuhar
Merge pull request #1132 from lidofinance/fix/oracle-doesnt-comsume-v…
0e6ae24 
…eb-limits

Dont limit oracle by common veb limit
@F4ever
Merge branch 'feat/triggerable-exits' into feat/triggerable-exits-atomic
2657f92
@F4ever
Merge pull request #1129 from lidofinance/feat/triggerable-exits-with…
1a78004 
…drawal-vault-permissions

Feat/triggerable exits withdrawal vault permissions
@F4ever
Merge branch 'feat/triggerable-exits' into feat/triggerable-exits-atomic
d35cd02
@F4ever
Merge pull request #1126 from lidofinance/feat/triggerable-exits-atomic
c218950 
Atomic exit requests unpack
@Amuhar
fix: veb review refactoring
4a46733
@Amuhar
Merge pull request #1133 from lidofinance/feat/veb-refactoring
d23c10b 
Veb refactoring
@Amuhar
fix: require -> revert
48fe102
@Amuhar
fix: getDeliveryTime -> getDeliveryTimestamp & require -> revert
be88294
@Amuhar
fix: rename value -> maxValidatorsPerReport
0794a35
@Amuhar
Merge pull request #1134 from lidofinance/feat/veb-refactoring
db2d479 
Exit limits utils lib : require -> revert
@mkurayan
feat: improve comments in withdrawal vault
cd35f7e
@mkurayan
feat: fix type in error name
fe013d2
@mkurayan
feat: fix typo in error name
d9fe8ba
@mkurayan
refactor: pass single property instead of entire object to inner func…
0900b19 
…tion in exit delay verifier
@mkurayan
Merge pull request #1135 from lidofinance/feat/triggerable-exits-veri…
666fb72 
…fier-linter

refactor: pass single property instead of entire object to inner func…
@mkurayan
feat: fix linter problems
e675406
@mkurayan
Merge pull request #1136 from lidofinance/feat/triggerable-exits-lint…
b77fe0c 
…er-problems

feat: fix linter problems
@mkurayan
feat: sr 2.0 update naming and comments
2b83a2a
@mkurayan
feat: clean-up text comments
bd1c794
@mkurayan
feat: fix comment
68eafaa
@mkurayan
feat: add test for trigger full withdrawals
d30d551
@Amuhar
fix: check wv event
c6f340c
F4ever
F4ever reviewed Sep 19, 2025
View reviewed changes
F4ever
F4ever reviewed Sep 19, 2025
View reviewed changes
F4ever
F4ever reviewed Sep 19, 2025
View reviewed changes
F4ever
F4ever reviewed Sep 19, 2025
View reviewed changes
F4ever
F4ever reviewed Sep 19, 2025
View reviewed changes
F4ever
F4ever reviewed Sep 19, 2025
View reviewed changes
F4ever
F4ever reviewed Sep 19, 2025
View reviewed changes
F4ever
F4ever reviewed Sep 19, 2025
View reviewed changes
F4ever
F4ever reviewed Sep 19, 2025
View reviewed changes
F4ever
F4ever reviewed Sep 19, 2025
View reviewed changes
F4ever and others added 13 commits September 23, 2025 15:17
TheDZhon
TheDZhon requested changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's provide one of the following before merging:

  • diffyscan logs WITH enabled bytecode checks
  • advanced-level approach: integrate diffyscan bytecode check with CI

@F4ever

TheDZhon
TheDZhon approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG

This was referenced Oct 13, 2025
Open
Open
Open
@tamtamchik tamtamchik merged commit 4bf7742 into master Oct 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@F4ever F4ever F4ever left review comments

@eddort eddort eddort left review comments

@TheDZhon TheDZhon TheDZhon approved these changes

@Ziars Ziars Ziars approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.