-
Notifications
You must be signed in to change notification settings - Fork 247
[EPIC] Triggerable Withdrawals (develop ⇒ master) #1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
564 commits
Select commit
Hold shift + click to select a range
a2dd3d4
fix: _consumeLimit
Amuhar 4350459
fix: refund test
Amuhar 5ae428c
Merge pull request #1130 from lidofinance/feat/refund-test
Amuhar 106a06d
refactor: clean-up withdrawal vault
mkurayan c2dda55
fix: MAX_VALIDATORS_PER_BATCH -> MAX_VALIDATORS_PER_REPORT
Amuhar 09f4697
fix: dont limit oracle by common veb limit
Amuhar 5f2bfec
Merge pull request #1131 from lidofinance/fix/exclude-batch-from-name
Amuhar 0e6ae24
Merge pull request #1132 from lidofinance/fix/oracle-doesnt-comsume-v…
Amuhar 2657f92
Merge branch 'feat/triggerable-exits' into feat/triggerable-exits-atomic
F4ever 1a78004
Merge pull request #1129 from lidofinance/feat/triggerable-exits-with…
F4ever d35cd02
Merge branch 'feat/triggerable-exits' into feat/triggerable-exits-atomic
F4ever c218950
Merge pull request #1126 from lidofinance/feat/triggerable-exits-atomic
F4ever 4a46733
fix: veb review refactoring
Amuhar d23c10b
Merge pull request #1133 from lidofinance/feat/veb-refactoring
Amuhar 48fe102
fix: require -> revert
Amuhar be88294
fix: getDeliveryTime -> getDeliveryTimestamp & require -> revert
Amuhar 0794a35
fix: rename value -> maxValidatorsPerReport
Amuhar db2d479
Merge pull request #1134 from lidofinance/feat/veb-refactoring
Amuhar cd35f7e
feat: improve comments in withdrawal vault
mkurayan fe013d2
feat: fix type in error name
mkurayan d9fe8ba
feat: fix typo in error name
mkurayan 0900b19
refactor: pass single property instead of entire object to inner func…
mkurayan 666fb72
Merge pull request #1135 from lidofinance/feat/triggerable-exits-veri…
mkurayan e675406
feat: fix linter problems
mkurayan b77fe0c
Merge pull request #1136 from lidofinance/feat/triggerable-exits-lint…
mkurayan 2b83a2a
feat: sr 2.0 update naming and comments
mkurayan bd1c794
feat: clean-up text comments
mkurayan 68eafaa
feat: fix comment
mkurayan d30d551
feat: add test for trigger full withdrawals
mkurayan c6f340c
fix: check wv event
Amuhar 9410bd5
fix: veb methods description
Amuhar 599894f
fix: veb methods description
Amuhar ff3aa12
Merge pull request #1139 from lidofinance/feat/triggerable-exits-inte…
Amuhar 289c191
Merge pull request #1140 from lidofinance/feat/desc-veb
Amuhar 69a4f0c
feat: add event for staking module exit notification failure and refa…
eddort 0408ea3
refactor: remove unused error handling and related test cases for TWG
eddort 7887d5e
refactor: remove unused import from stakingRouter tests
eddort 891459e
fix: oracle allow to update delivery time if report was not submitted…
Amuhar ce097e6
feat: use eip7002 contract byte code in integration tests
mkurayan 1f207ad
fix: added event ExitDataProcessing for oracle submit
Amuhar 4c35d8b
Merge pull request #1145 from lidofinance/feat/allow-oracle-update-re…
Amuhar 2263577
feat: ignore fails on exit delay report
mkurayan 754ebdb
feat: upgrade StakingRouter contract to version 3 and update related …
eddort 28f6668
Merge pull request #1147 from lidofinance/feat/triggerable-exits-igno…
mkurayan d3c678e
Merge pull request #1148 from lidofinance/fix/sr-add-v3-update-method
eddort 649e41a
Merge pull request #1146 from lidofinance/feat/triggerable-exits-inte…
mkurayan 8beee97
Merge pull request #1138 from lidofinance/feat/sr-2.0-update-comments…
mkurayan 27ef3c7
Merge branch 'feat/triggerable-exits' of github.com:lidofinance/core …
eddort e0e6bb5
refactor: move for loop from twg to sr
eddort 2dfda2f
refactor: update exit delay reporting logic to return instead of reve…
eddort 82340e4
Revert "feat: ignore fails on exit delay report"
eddort 73caecf
test: update validator exit delay verification to expect no reversion…
eddort 821f015
refactor: add comment about UnrecoverableModuleError in onValidatorEx…
eddort 0b4a52e
Update contracts/0.8.9/StakingRouter.sol
eddort aaf7fd5
Revert "refactor: update exit delay reporting logic to return instead…
eddort 009b401
Revert "test: update validator exit delay verification to expect no r…
eddort ab81a52
refactor: streamline validator exit reporting logic
eddort c03fc32
test: update validator exit delay verification to expect successful e…
eddort ac64917
fix: uint/intergation tests
Amuhar 1f91ae2
Merge branch 'feat/triggerable-exits' into feat/impr-tests
Amuhar a6134d0
fix: test
Amuhar 1db6c8d
fix: role
Amuhar 9223f6e
Merge pull request #1143 from lidofinance/feat/add-try-catch-to-tw-hook
F4ever 213bcfc
fix: replace error: prefix in revertedWithOZAccessControlError with e…
Amuhar 4bb4b33
refactor: swap IncorrectFee args in WithdrawalVaultEIP7002
mkurayan fa1a8a8
Merge pull request #1150 from lidofinance/feat/triggerable-exits-mino…
F4ever 1008ebb
Merge pull request #1149 from lidofinance/feat/impr-tests
Amuhar 4bad6cc
fix: spaces
Amuhar 26ebd30
Merge pull request #1151 from lidofinance/fix/spaces
F4ever 29bbfd1
refactor: NOR, SR and AO refactoring
eddort a826afe
fix: update copyright year to 2025 in ValidatorsExitBusOracle.sol
eddort 628c873
Merge pull request #1152 from lidofinance/refactor/tw-nor-sr-review
F4ever cea798f
feat: full unit tests coverage for NOR
eddort 0f47ad0
feat: add mock staking module and tests for tw functionality
eddort 91fb537
feat: upgrade tests for AccountingOracle
eddort 2fa8edb
fix: remove unused import ZeroAddress
eddort 81f1ddf
feat: reimplement GIndex test in ts
eddort c16db3b
refactor: clean up GIndex test imports and improve readability
eddort 7856add
refactor: rename utils contract for GIndex
eddort bf0bb4d
Update contracts/0.8.25/lib/SSZ.sol
mkurayan 8792f57
Merge pull request #1158 from lidofinance/feat/rewrite-gindex-test-to-hh
eddort 27f6906
feat: move BeaconTypes, SSZ and GIndex to common folder
mkurayan fe7df70
Update contracts/common/lib/BeaconTypes.sol
mkurayan 3c39926
fix: add solhint-disable
mkurayan 5101cb8
Merge commit 'bf0bb4dd179d42ca21306a86b9c08de0dddb47e6' into fix/tw-n…
mkurayan 8b08c5e
Merge pull request #1156 from lidofinance/fix/tw-nor-sr-coverage
F4ever b64b1c1
feat: add withdrawal vault integration tests
mkurayan fe9bf71
Merge pull request #1160 from lidofinance/feat/triggerable-exits-add-…
mkurayan 6db5b90
feat: use via-ir for solidity 0.8.25
mkurayan 4c1730d
try out heap tweak with IR
TheDZhon 9a18a59
Update coverage.yml
TheDZhon cc23910
Merge pull request #1171 from lidofinance/te-via-ir-ci
mkurayan 59b2ff2
Merge pull request #1166 from lidofinance/feat/triggerable-exits-via-ir
F4ever 1053ef6
feat: deploy configuration for holesky testnet
eddort 61a6c16
feat: refactor deployment script for triggerable withdrawals
eddort 9374f78
fix: locator config in tw deploy script
eddort c0d35b1
refactor: move consensus-spec constants to chainSpec for better confi…
eddort 3bbd295
refactor: update triggerable withdrawals parameters
eddort 8079bc9
refactor: remove unused .env.sample and tw-verify.ts files
eddort b7a11ef
refactor: remove deprecated refunded validators count functionality
eddort fb3082d
Merge pull request #1174 from lidofinance/fix/remove-refunded-logic-f…
eddort 0900379
fix: contracts verification
eddort 72d4713
Merge branch 'feat/tw-deploy-holesky' of github.com:lidofinance/core …
eddort 886a256
Merge pull request #1172 from lidofinance/feat/tw-deploy-holesky
F4ever 8c5f90d
feat(deploy-holesky): deploy contracts on holesky
chasingrainbows 831ec2c
feat: update addWithdrawalRequests method comment
mkurayan eb47249
Merge pull request #1184 from lidofinance/feat/triggerable-exits-fix-…
F4ever e657dca
feat: add new GateSeal types and implement deployGateSeal function
eddort c7372de
refactor: make imports abs and move a few interfaces to common
arwer13 14d785e
feat: refactor GateSeal types and update deployGateSeal function para…
eddort a5848c5
feat: make NETWORK variable configurable in deploy-tw script
eddort d0583b7
feat: add legacy support for depositContract in chain spec
eddort ce8cf5a
fix: correct GATE_SEAL_EXPIRY_TIMESTAMP
eddort 8597ae3
feat: deploy new gateSeals to holesky testnet
eddort 5c78974
fix: bump accounting oracle initial version to 3
eddort d262d81
Merge pull request #1204 from lidofinance/fix/tw-ao-initialize-v3
eddort a9bc3df
fix: audit
Amuhar 18a890b
fix: comment impr
Amuhar c85737f
fix: update AccountingOracle implementation address for Holesky TW de…
eddort dc86473
fix: TOTAL_REQUESTS_PROCESSED_POSITION for oracle and other entities …
Amuhar ff246ef
fix: format
Amuhar 5eaa9f8
Merge pull request #1196 from lidofinance/refactor/abs-contract-imports
arwer13 133ba19
Merge pull request #1193 from lidofinance/feat/gate-seal-tw
eddort 2a25c7a
Merge pull request #1206 from lidofinance/fix/orc-424-audit-fixes
Amuhar 7c883c8
fix: update deployGateSeal calls to use updated network state
eddort 0c22026
wip: update validator exit delay verifier
eddort 3ee467c
wip: unit tests
eddort daa035a
fix: update validator exit delay verifier parameters and historical r…
eddort 38ec1a3
fix: update ValidatorExitDelayVerifier deployment parameters and test…
eddort 6c16d36
fix: update EVM version to Prague and adjust int type formatting
eddort d00277d
fix: enable IR optimization for fuzzing and invariant tests
eddort 9360a66
refactor: remove GIndex test file
eddort b981157
fix: remove --via-ir flag from fuzzing and invariant tests
eddort a2e8b14
fix: update validatorProof
eddort af574fd
fix: update validator exit delay parameters with active validator pro…
eddort 5259c03
refactor: consolidate GIndex parameters into a single GIndices struct…
eddort d3a6861
Revert "refactor: remove GIndex test file"
eddort 19d3786
feat: update deploy TW script
eddort 00aabce
refactor: rename historical GIndex variables and optimize gas usage i…
eddort b7eac13
refactor: update GIndex variable documentation
eddort 38b3ecb
refactor: add TODO comment to update Capella slot for e2e testing in …
eddort 52dfddb
Remove redundant zero check
hweawer 8b2dc8f
Change timestamp comparison method
hweawer 59a8ecb
Try fix unit test
hweawer b0ac708
Add test
hweawer 6bb3464
Fix test
hweawer 1066590
Fix test
hweawer 6a773b1
Merge branch 'feat/triggerable-exits' of github.com:lidofinance/core …
eddort 8e2f2ec
Merge pull request #1227 from lidofinance/fix/remove-redundant-delive…
F4ever 3493aaa
feat: Emit an event when the maximum number of validator exits per re…
Amuhar 498d5da
Remove redundant version check
hweawer 26bea4d
feat: add underflow protection and tests for setExitDeadlineThreshold…
eddort 7ec530d
refactor: reuse variable in verifyValidatorExitDelay
eddort 9a366e1
Merge branch 'feat/tw-verifier-improvements' of github.com:lidofinanc…
eddort d3ada7a
docs: update deprecation notice for updateTargetValidatorsLimits func…
eddort dfa2805
Merge pull request #1234 from lidofinance/fix/audit-ackee
F4ever 5b1e442
refactor: update getFrameConfig to include fastLaneLengthSlots
eddort 5f33c41
Merge pull request #1236 from lidofinance/fix/setexitdeadlinethreshol…
eddort 2c3b01d
Merge pull request #1237 from lidofinance/fix/outdated-iconsensuscont…
eddort 91545ab
Merge pull request #1225 from lidofinance/feat/tw-verifier-improvements
eddort 2f3abe1
Merge pull request #1235 from lidofinance/fix/remove-redundant-versio…
hweawer 5c36fa4
fix: setExitLimits
Amuhar 9db1683
Add tests
hweawer 58eaada
Merge pull request #1240 from lidofinance/feat/exit-limit-utils-audit…
F4ever 058a0b6
feat: move TW to in-contract defined interfaces
arwer13 3ab6087
fix: update contract addresses and clean up JSON configurations
eddort 033f46b
feat: add utility to check local interfaces and fix them
arwer13 36b4e93
feat: deploy-tw -> tw-deploy
eddort 5b0c8df
fix: define SLOTS_PER_HISTORICAL_ROOT constant for clarity
eddort d679b01
fix: review deploy script
eddort 4c99d26
feat: tweak exit delay tests
F4ever aa4caaf
Merge pull request #1246 from lidofinance/fix/deploy-hoodi
F4ever 28c62bf
Merge pull request #1245 from lidofinance/fix/untacked-sources-change
F4ever cfa0c6a
feat(tw): add sleep to verifyContract to avoid API errors
chasingrainbows 812a45d
feat(tw-hoodi): add deployed-hoodi.json
chasingrainbows fa84002
wip: upgrade protocol on fork
eddort 3c87a13
wip: deploy aragon script
eddort 8c96423
wip: aragon mock
eddort 67bc2f0
feat: aragon voting for tw
eddort e5d2673
fix: TWVoteScript build
eddort 75e3e7c
wip: deploy params and state file
eddort 23d10e8
wip: integration test fixes
eddort 0cf698d
feat(orc-420): unskip sdvt related tests
chasingrainbows d22abba
feat(orc-420): add sdvt to vote
chasingrainbows 865fcfb
feat(orc-420): unskip tests
chasingrainbows d1a1d00
feat(orc-420): add voting to CI
chasingrainbows 52ef8ef
feat(orc-420): bring back oracles
chasingrainbows f65995e
fix: remove usused gindex from verifier
F4ever a69ddf4
feat(orc-420): shut up linter
chasingrainbows 6087ba4
feat(orc-420): fix tests for DG
chasingrainbows 32fd517
feat(orc-420): add ir for voting script
chasingrainbows ce5e3e5
feat(orc-420): fix signatures
chasingrainbows 0f2876b
feat(orc-420): improve run tests script
chasingrainbows 3e89cd3
feat(orc-420): fix validatorExitDelayVerifierArgs
chasingrainbows b9f2066
feat(orc-420): fix staking limits dependent tests
chasingrainbows c871466
feat(orc-420): remove old code
chasingrainbows d30d2b2
fix: remove deployed-mainnet-upgrade.json
eddort 870e0b8
feat: remove unused test-scratch-upgrade.sh script
eddort b8ec4f4
refactor: remove unused overrides from Hardhat config and console log…
eddort c0a51de
Merge pull request #1314 from lidofinance/fix/remove-unsued-param-fro…
F4ever 62237e5
feat: add IOssifiableProxy interface and update getAddress function t…
eddort eba21f7
Merge pull request #1289 from lidofinance/feat/tw-deployed-hoodi-json
eddort f3ba19c
Merge pull request #1242 from lidofinance/feature/orc-420-fix-tw-depl…
eddort 8f0c4a4
Merge branch 'feat/triggerable-exits' of github.com:lidofinance/core …
eddort 5356868
Merge branch 'develop' of github.com:lidofinance/core into feat/trigg…
eddort 015b99c
Merge branch 'feat/triggerable-exits' of github.com:lidofinance/core …
eddort 8406338
fix: update import path for IStakingModule in ICSModule interface
eddort bcf57ed
fix: remove stuckKeys from extra data preparation in submitMainReport…
eddort 3d5e849
fix: remove stuckKeys handling and update exitedKeys logic in account…
eddort f9f32ec
Merge pull request #1228 from lidofinance/fix/change-verifier-comparison
eddort 429ef9e
fix: remove stuck items reporting and related logic in accounting ora…
eddort 85c027d
fix: remove unused reportTx variable in accounting oracle integration…
eddort 8635059
fix: add gas estimation and logging for transaction and deployment pr…
eddort e34246c
Revert "fix: add gas estimation and logging for transaction and deplo…
eddort b9d4222
fix: remove stuck items reporting and related logic in accounting ora…
eddort a6d8231
Merge pull request #1353 from lidofinance/feat/triggerable-exits-merg…
eddort f531dde
fix: update network configuration for hoodi and redeploy locator + tw…
eddort 7547265
Merge pull request #1356 from lidofinance/feat/triggerable-exits-hood…
eddort e83f5a2
Merge pull request #1018 from lidofinance/feat/triggerable-exits
tamtamchik e36f72f
chore: adjust calculation of historical block root gI
madlabman 55e32d5
test: port tests for getHistoricalBlockRootGI
madlabman acf3188
Merge pull request #1393 from lidofinance/historical-block-root-gi
tamtamchik 061e27d
feat(tw-deploy): gateseal state and network state var
hweawer b5a5ecf
Revert test deploy
hweawer 381a03d
Merge pull request #1402 from lidofinance/feat/fix-deploy-tw-mainnet
tamtamchik db598c1
fix(tw-deploy): Fix CAPELLA_SLOT for mainnet
hweawer 5941659
Merge pull request #1405 from lidofinance/feat/fix-capella-slot-tw-de…
tamtamchik 9133ba5
fix(tw-deploy): Fix slots for verifier
hweawer 1c58efa
Merge pull request #1409 from lidofinance/feat/tw-fix-slots
tamtamchik 2feb83f
Update hoodi state after TW redeploy
hweawer c9ef333
Merge pull request #1415 from lidofinance/update-tw-hoodi-state
tamtamchik 100a2a4
chore: update readme
mkurayan 3d18a60
Merge pull request #1434 from lidofinance/feat/update-readme
tamtamchik 3c5737a
fix: update test script to run all unit tests
eddort 33b2475
feat: add mainnet configuration to Hardhat config
eddort 3247a42
feat: tw deploy on mainnet
F4ever cf48a1f
Merge pull request #1439 from lidofinance/fix/package-json-test-script
tamtamchik bb80f34
fix: deploy contract
F4ever 85afa92
fix: update tw verifier deploy
F4ever 4566418
fix: update dualgov contract
F4ever 4101ddc
chore: update fixture for validator proof
madlabman 9d2debf
Merge pull request #1462 from lidofinance/fixture
F4ever e87c073
fix: units params
F4ever b738605
feat: add description for values
F4ever 4b43a17
Merge pull request #1460 from lidofinance/fix/tw-deploy
tamtamchik e1146b8
fix: scratch deploy after TW release
F4ever 37e016e
chore: merge dev
F4ever 6e44ac8
Merge pull request #1440 from lidofinance/feat/tw-deploy-mainnet
tamtamchik 1a483a4
Merge branch 'develop' of github.com:lidofinance/core into fix/scratc…
F4ever 39ba170
Merge pull request #1483 from lidofinance/fix/scratch-deploy-tw
tamtamchik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,7 +65,7 @@ Please refer to the [Lido Contributor Code of Conduct](/CODE_OF_CONDUCT.md). | |
|
||
## License | ||
|
||
2024 Lido <[email protected]> | ||
2025 Lido <[email protected]> | ||
|
||
This program is free software: you can redistribute it and/or modify | ||
it under the terms of the GNU General Public License as published by | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.