[TechDebt]: VEBO — post Triggerable Withdrawals review cleanup #1503
Description
Summary
Post-review improvements for ValidatorsExitBusOracle.sol and ValidatorsExitBus.sol.
Context
Comments deferred from PR #1382:
- outdated doc
- wrong formatting
- it is necessary to add additional documentation
- make the method public
- add comment that total requests counter can contain duplicates
- update doc
- non-critical abstraction leak
- the inheritance order differs from BaseOracle
- better declare format before data
- the method could be inlined
- fix doc
- better variable be named maxValidatorsPerReport
- inconsistent return values. Better moduleId, nodeOpId, valIndex, pubkey
- explicit return is redundant
- whenPaused is redundant
- rethink _getTimestamp implementation
- _setupRole() is deprecated in favor of {_grantRole}
- worth delete this note at all