Refactoring: typescript #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2022
Empty or non-existent
ignore_php_platform_requirements does not disable PHP 8.0 default behavior
#80
Closed
internalsystemerror
approved these changes
Apr 7, 2022
Merged
Ocramius
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
FML, this has been open for over 6 months? Really sorry for that, @boesing :-(
I took a slow read through it, my TS-fu is low, but I didn't see any particular scary usages of casts and any or unknown, so IMO 🚢 at your will.
I will gladly try out the new version on my repos!
boesing
force-pushed
the
refactor/typescript
branch
from
14ac0b9
to
3d87a8b
Compare
|
This is starting to look more green-ish 💪 |
boesing
force-pushed
the
refactor/typescript
branch
4 times, most recently
from
475b1f1
to
eb48252
Compare
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
… the latest version available Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
… set Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
…bility Signed-off-by: Maximilian Bösing <[email protected]>
… for PHP versions Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
…ocked` dependencies here Signed-off-by: Maximilian Bösing <[email protected]>
I am not 100% sure what is happening here, but somehow, if the ternary operator is not wrapped in brackets, the null-safe operator does work as expected and the value of the ternary operation is being used instead Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
…rather than `locked` Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
refactor/typescript
branch
from
eb48252
to
7f9306f
Compare
Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
refactor/typescript
branch
from
7c56394
to
c9676b4
Compare
…laminas-ci.schema.json` Signed-off-by: Maximilian Bösing <[email protected]>
…e `.laminas-ci.json` Signed-off-by: Maximilian Bösing <[email protected]>
This also adds an action failure to whenever a schema could not be detected. Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converted the application to typescript.
In combination with #62, this supposed to be a major improvement when it comes to new features.
This also reduces the container size from 426MB to 188MB which is a total amount of ~56%!
Features which are implemented in this PR
Bugs which are fixed in this PR
@lowestand@latestis not respected when project provides explicitchecks#84ignore_php_platform_requirementsdoes not disable PHP 8.0 default behavior #80Open TODOs
excludewhich was implemented here.laminas-ci.schema.jsonis not properly verified, it does not contain@latestor@lowestfor thephpentry but integration tests are passingIdeas which could be implemented later on
.laminas-ci.schema.jsonfrom typescript interfaces using typescript-json-schema - would target Simplify.laminas-ci.json#54 (addressed in Generate.laminas-ci.schema.jsonfrom typescript interfaces rather than maintaining it manually #95)phpunit.xml.distis the only file within the diff) (addressed in Enable code checks or linters when files from tools are changed (i.e. run all PHPUnit checks whenphpunit.xml.distis the only file within the diff) #94)excludeto use the toolsnamealong with aphpanddependenciesproperty:{"name": "PHPUnit", "php": "*"}(addressed in Allowphpanddependencyinexcludealong withnamereflecting the tools/checks name #93)diffoutput for better readability in case of differences (addressed in Optimizediffwithin CI pipeline output for better readability in case of failing tests #92)