-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: typescript #83
Commits on Jun 29, 2022
-
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fbc69a5 - Browse repository at this point
Copy the full SHA fbc69a5View commit details -
bugfix: surround string value when it contains colon
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fb30cea - Browse repository at this point
Copy the full SHA fb30ceaView commit details -
bugfix: provide working github workflow
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aa84618 - Browse repository at this point
Copy the full SHA aa84618View commit details -
qa: remove
node-version
fromactions/setup-node
to always install…… the latest version available Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 003998e - Browse repository at this point
Copy the full SHA 003998eView commit details -
bugfix: remove empty-object annotations
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f5553e5 - Browse repository at this point
Copy the full SHA f5553e5View commit details -
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for baaa240 - Browse repository at this point
Copy the full SHA baaa240View commit details -
qa: revert weird spacing for
${}
surrounded variables/function callsSigned-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f1b03b7 - Browse repository at this point
Copy the full SHA f1b03b7View commit details -
qa: remove
@babel/eslint-parser
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 48095e1 - Browse repository at this point
Copy the full SHA 48095e1View commit details -
qa: use node v17 rather than
current
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4aac396 - Browse repository at this point
Copy the full SHA 4aac396View commit details -
refactoring: convert application to typescript
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8ee9057 - Browse repository at this point
Copy the full SHA 8ee9057View commit details -
bugfix: add
tsconfig.json
astsconfig.json
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 74fb8c1 - Browse repository at this point
Copy the full SHA 74fb8c1View commit details -
bugfix: use script from
package.json
to run lintingSigned-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cb10195 - Browse repository at this point
Copy the full SHA cb10195View commit details -
qa: add
noUncheckedIndexedAccess
Since it is not included within `strictNullChecks` which is enabled via the `strict` flag, we want to enable this flag manually. Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eb6b330 - Browse repository at this point
Copy the full SHA eb6b330View commit details -
qa: remove unnecessary constant
Due to verbosity, a constant was added for the removal of the first two arguments of the process. Instead of using that constant, a more verbose comment was added. Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5e7a03f - Browse repository at this point
Copy the full SHA 5e7a03fView commit details -
qa: add
pattern
tophp
JSON schemaBy using a pattern, we can verify that the `php` property always contains a version in the format of `\d+.\d+` Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fbc95b5 - Browse repository at this point
Copy the full SHA fbc95b5View commit details -
feature: deduplicate the generated additional checks
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 58b1d3a - Browse repository at this point
Copy the full SHA 58b1d3aView commit details -
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1b9a171 - Browse repository at this point
Copy the full SHA 1b9a171View commit details -
Remove spaces added by
eslint --fix
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 08f6446 - Browse repository at this point
Copy the full SHA 08f6446View commit details -
Rename
createConfig
tocreateConfigObject
to better reflect what ……is being returned Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5f05c4c - Browse repository at this point
Copy the full SHA 5f05c4cView commit details -
Use
tilde
operator to pin typescript to a patch versionTypescript introduces BC breaks in minors and thus its better to pin it to a specific minor and only allow patches. Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4844cfa - Browse repository at this point
Copy the full SHA 4844cfaView commit details -
refactoring: remove
Logger
interface fromAction
interfaceInstead, we now do provide a `Action#getLogger` method to provide a logger based on the action we are using. Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3d26831 - Browse repository at this point
Copy the full SHA 3d26831View commit details -
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd08b2e - Browse repository at this point
Copy the full SHA dd08b2eView commit details -
refactor: rename
ComposerDependency
toComposerDependencySet
To provide a slightly more verbose meaning of what is inside the configuration, renaming `dependency` to `dependencySet` might help. The dependency set does actually reflect the `lowest` dependencies, `latest` dependencies or `locked` dependencies for the project running this action. Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for efa360d - Browse repository at this point
Copy the full SHA efa360dView commit details -
feature: split docker build into multi-layer build
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6dd19e6 - Browse repository at this point
Copy the full SHA 6dd19e6View commit details -
feature: build container within CI
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd2c736 - Browse repository at this point
Copy the full SHA dd2c736View commit details -
Due to security regulations, secrets are not accessible in pull requests and thus we should skip the login. Logging in is only required for pushing images and since we do not push, we can skip it safely. Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 622fef4 - Browse repository at this point
Copy the full SHA 622fef4View commit details -
feature: download composer JSON schema from getcomposer.org
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 58d84bf - Browse repository at this point
Copy the full SHA 58d84bfView commit details -
bugfix: convert file buffer to string before parsing to JSON
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0677ce1 - Browse repository at this point
Copy the full SHA 0677ce1View commit details -
bugfix: use enum for
php
property within ajob
Since we do have to manually add every upcoming PHP version, adding that version to this list might be possible as well. Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2e6bc45 - Browse repository at this point
Copy the full SHA 2e6bc45View commit details -
qa: normalize
continuous-integration.yml
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9ad85b9 - Browse repository at this point
Copy the full SHA 9ad85b9View commit details -
qa: disable
@typescript-eslint/no-inferrable-types
as we stricter i……s better Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a3c96a0 - Browse repository at this point
Copy the full SHA a3c96a0View commit details -
qa: disable
object-shorthand
check as we do want to be more explicitHaving "magic" to detect the property name is not really preferred. Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 564297f - Browse repository at this point
Copy the full SHA 564297fView commit details -
qa: optimize
eslint
and fixed some issuesSigned-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 47bcf43 - Browse repository at this point
Copy the full SHA 47bcf43View commit details -
qa: remove unnecessary annotations
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d5df1f8 - Browse repository at this point
Copy the full SHA d5df1f8View commit details -
bugfix: remove possibly unused
awesome-typescript-loader
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 20b452c - Browse repository at this point
Copy the full SHA 20b452cView commit details -
bugfix: tell docker container within GHA that it is actually a GHA
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bf0b3ae - Browse repository at this point
Copy the full SHA bf0b3aeView commit details -
bugfix: pass all host environment variables to the container
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 487adaf - Browse repository at this point
Copy the full SHA 487adafView commit details -
enhancement: use
GITHUB_ACTIONS
environment variable rather than `G……ITHUB_ACTION` while also having `Github` as default action Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 71b77af - Browse repository at this point
Copy the full SHA 71b77afView commit details -
docs: add some description on why we do use
GITHUB_ACTIONS
environm……ent variable Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1ee4905 - Browse repository at this point
Copy the full SHA 1ee4905View commit details -
bugfix: remove
GITHUB_ACTIONS
environment variable from CI as we do…… only want to consume that if this action is being used as an action Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8846628 - Browse repository at this point
Copy the full SHA 8846628View commit details -
bugfix: ensure
latest
dependencies for projects without `composer.l……ock` Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99dbef9 - Browse repository at this point
Copy the full SHA 99dbef9View commit details -
bugfix:
No checks
check always contains staticlocked
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e6c66e9 - Browse repository at this point
Copy the full SHA e6c66e9View commit details -
qa: add integration test for project with
composer.lock
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 65e619d - Browse repository at this point
Copy the full SHA 65e619dView commit details -
revert: change back to
diff
so we get more readable outputSigned-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6ad9784 - Browse repository at this point
Copy the full SHA 6ad9784View commit details -
feature: add PHP version and composer dependency set to output check …
…name Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 55b78ce - Browse repository at this point
Copy the full SHA 55b78ceView commit details -
bugfix: restore initial
diff
commandSigned-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 32be08b - Browse repository at this point
Copy the full SHA 32be08bView commit details -
qa: add integration tests for
exclude
to verify projects can exclud……e in the old way Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 677e816 - Browse repository at this point
Copy the full SHA 677e816View commit details -
qa: rework
sanityChecksPassing
to doassertions
rather than alway……s returning `true` Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for db517d5 - Browse repository at this point
Copy the full SHA db517d5View commit details -
bugfix: remove unnecessary
node
call from CI as it pollutes the diffSigned-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b323d65 - Browse repository at this point
Copy the full SHA b323d65View commit details -
qa: remove unnecessary variable
REQUIRE_CHECKS=true
from `entrypoin……t.sh` Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for deef576 - Browse repository at this point
Copy the full SHA deef576View commit details -
feature: use
webpack.BannerPlugin
to add shebang to generated `main…….js` This `main.js` is now used in the `entrypoint` without prefixing the executable. The `main.js` is now also used within the `CI` pipeline to avoid using the `entrypoint.sh` magic which suppresses the `diff` when it is not being detected from the GIT repository Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5d9ce00 - Browse repository at this point
Copy the full SHA 5d9ce00View commit details -
feature: output files used for generating the configuration via
debug
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 90a5198 - Browse repository at this point
Copy the full SHA 90a5198View commit details -
qa: create test to verify that we do not run code checks for docs onl…
…y diffs Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 08430d2 - Browse repository at this point
Copy the full SHA 08430d2View commit details -
qa: add test for code checks without linting even tho the markdown fi…
…le does exist Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8364da0 - Browse repository at this point
Copy the full SHA 8364da0View commit details -
qa: add integration test for
.laminas-ci.json
changeThis should trigger all checks even tho the diff contains nothing else. Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1c2d551 - Browse repository at this point
Copy the full SHA 1c2d551View commit details -
qa: ensure that we do not run any check if non-PHP and non-markdown f…
…iles are changed Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f06c9f2 - Browse repository at this point
Copy the full SHA f06c9f2View commit details -
bugfix: use more readable length check
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 636648f - Browse repository at this point
Copy the full SHA 636648fView commit details -
bugfix: do not run docker with
-t
since we are not in a TTYSigned-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6ff3cb8 - Browse repository at this point
Copy the full SHA 6ff3cb8View commit details -
bugfix: show proper step name within job
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4e56746 - Browse repository at this point
Copy the full SHA 4e56746View commit details -
bugfix: add backwards compatibility for old job exclusions
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b5afb6d - Browse repository at this point
Copy the full SHA b5afb6dView commit details -
docs: update
exclude
examples to reflect latest changesSigned-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f347807 - Browse repository at this point
Copy the full SHA f347807View commit details -
qa: enhance deprecated exclusion test
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4e524e5 - Browse repository at this point
Copy the full SHA 4e524e5View commit details -
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ea158df - Browse repository at this point
Copy the full SHA ea158dfView commit details -
bugfix: fix tool name in expected matrix output
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 49120eb - Browse repository at this point
Copy the full SHA 49120ebView commit details -
bugfix: ensure that job definitions are always created via
createJob
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 41ebcfa - Browse repository at this point
Copy the full SHA 41ebcfaView commit details -
qa: we should expect
latest
in projects withoutcomposer.lock
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 73bc9c3 - Browse repository at this point
Copy the full SHA 73bc9c3View commit details -
bugfix: ensure that expected matrix is generated as expected by addin…
…g `composer.json` and `composer.lock` Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c7439e2 - Browse repository at this point
Copy the full SHA c7439e2View commit details -
bugfix: initialize variable before pushing
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ff69543 - Browse repository at this point
Copy the full SHA ff69543View commit details -
bugfix:
No checks
check will not provide PHP or composer dependency…… set Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 124c789 - Browse repository at this point
Copy the full SHA 124c789View commit details -
bugfix: ensure tests properly reflect what we do want to verify
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5871d45 - Browse repository at this point
Copy the full SHA 5871d45View commit details -
bugfix: ensure backwards compatibility for deprecated exclusions
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 227a98e - Browse repository at this point
Copy the full SHA 227a98eView commit details -
bugfix: provide tool information via job to provide backwards compati…
…bility Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b1737c8 - Browse repository at this point
Copy the full SHA b1737c8View commit details -
bugfix: properly detected
@latest
and@lowest
from job definition…… for PHP versions Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 450e390 - Browse repository at this point
Copy the full SHA 450e390View commit details -
qa: ensure line-length is not exceeded
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cbd2a8f - Browse repository at this point
Copy the full SHA cbd2a8fView commit details -
bugfix: we do have
locked
dependencies and thus we should expect `l……ocked` dependencies here Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b66d3b1 - Browse repository at this point
Copy the full SHA b66d3b1View commit details -
bugfix: wrap ternary operation in brackets
I am not 100% sure what is happening here, but somehow, if the ternary operator is not wrapped in brackets, the null-safe operator does work as expected and the value of the ternary operation is being used instead Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f794686 - Browse repository at this point
Copy the full SHA f794686View commit details -
qa: expected output should not double quote the job
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 972aa8d - Browse repository at this point
Copy the full SHA 972aa8dView commit details -
bugfix: since no
composer.lock
is available, we do expectlatest
……rather than `locked` Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7f9306f - Browse repository at this point
Copy the full SHA 7f9306fView commit details -
bugfix: PHP 8.0 platform requirements are not ignored by default anymore
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c9676b4 - Browse repository at this point
Copy the full SHA c9676b4View commit details
Commits on Jun 30, 2022
-
bugfix: ensure we properly validate the
.laminas-ci.json
with the `……laminas-ci.schema.json` Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ad517a1 - Browse repository at this point
Copy the full SHA ad517a1View commit details -
bugfix: allow
@lowest
and@latest
forphp
information within th……e `.laminas-ci.json` Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f089a42 - Browse repository at this point
Copy the full SHA f089a42View commit details -
bugfix: use proper
composer.schema.json
nameThis also adds an action failure to whenever a schema could not be detected. Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 081d677 - Browse repository at this point
Copy the full SHA 081d677View commit details -
Signed-off-by: Maximilian Bösing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6733c63 - Browse repository at this point
Copy the full SHA 6733c63View commit details