Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: typescript #83

Merged
merged 83 commits into from
Jul 3, 2022
Merged

Commits on Jun 29, 2022

  1. feature: introduce ESLint

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    fbc69a5 View commit details
    Browse the repository at this point in the history
  2. bugfix: surround string value when it contains colon

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    fb30cea View commit details
    Browse the repository at this point in the history
  3. bugfix: provide working github workflow

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    aa84618 View commit details
    Browse the repository at this point in the history
  4. qa: remove node-version from actions/setup-node to always install…

    … the latest version available
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    003998e View commit details
    Browse the repository at this point in the history
  5. bugfix: remove empty-object annotations

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f5553e5 View commit details
    Browse the repository at this point in the history
  6. qa: switch to npm ci

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    baaa240 View commit details
    Browse the repository at this point in the history
  7. qa: revert weird spacing for ${} surrounded variables/function calls

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f1b03b7 View commit details
    Browse the repository at this point in the history
  8. qa: remove @babel/eslint-parser

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    48095e1 View commit details
    Browse the repository at this point in the history
  9. qa: use node v17 rather than current

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    4aac396 View commit details
    Browse the repository at this point in the history
  10. refactoring: convert application to typescript

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    8ee9057 View commit details
    Browse the repository at this point in the history
  11. bugfix: add tsconfig.json as tsconfig.json

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    74fb8c1 View commit details
    Browse the repository at this point in the history
  12. bugfix: use script from package.json to run linting

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    cb10195 View commit details
    Browse the repository at this point in the history
  13. qa: add noUncheckedIndexedAccess

    Since it is not included within `strictNullChecks` which is enabled via the `strict` flag, we want to enable this flag manually.
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    eb6b330 View commit details
    Browse the repository at this point in the history
  14. qa: remove unnecessary constant

    Due to verbosity, a constant was added for the removal of the first two arguments of the process.
    Instead of using that constant, a more verbose comment was added.
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    5e7a03f View commit details
    Browse the repository at this point in the history
  15. qa: add pattern to php JSON schema

    By using a pattern, we can verify that the `php` property always contains a version in the format of `\d+.\d+`
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    fbc95b5 View commit details
    Browse the repository at this point in the history
  16. feature: deduplicate the generated additional checks

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    58b1d3a View commit details
    Browse the repository at this point in the history
  17. Remove all linting issues

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    1b9a171 View commit details
    Browse the repository at this point in the history
  18. Remove spaces added by eslint --fix

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    08f6446 View commit details
    Browse the repository at this point in the history
  19. Rename createConfig to createConfigObject to better reflect what …

    …is being returned
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    5f05c4c View commit details
    Browse the repository at this point in the history
  20. Use tilde operator to pin typescript to a patch version

    Typescript introduces BC breaks in minors and thus its better to pin it to a specific minor and only allow patches.
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    4844cfa View commit details
    Browse the repository at this point in the history
  21. refactoring: remove Logger interface from Action interface

    Instead, we now do provide a `Action#getLogger` method to provide a logger based on the action we are using.
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    3d26831 View commit details
    Browse the repository at this point in the history
  22. qa: remove redundant constant

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    dd08b2e View commit details
    Browse the repository at this point in the history
  23. refactor: rename ComposerDependency to ComposerDependencySet

    To provide a slightly more verbose meaning of what is inside the configuration, renaming `dependency` to `dependencySet` might help.
    The dependency set does actually reflect the `lowest` dependencies, `latest` dependencies or `locked` dependencies for the project running this action.
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    efa360d View commit details
    Browse the repository at this point in the history
  24. feature: split docker build into multi-layer build

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    6dd19e6 View commit details
    Browse the repository at this point in the history
  25. feature: build container within CI

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    dd2c736 View commit details
    Browse the repository at this point in the history
  26. bugfix: do not login in CI

    Due to security regulations, secrets are not accessible in pull requests and thus we should skip the login. Logging in is only required for pushing images and since we do not push, we can skip it safely.
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    622fef4 View commit details
    Browse the repository at this point in the history
  27. feature: download composer JSON schema from getcomposer.org

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    58d84bf View commit details
    Browse the repository at this point in the history
  28. bugfix: convert file buffer to string before parsing to JSON

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    0677ce1 View commit details
    Browse the repository at this point in the history
  29. bugfix: use enum for php property within a job

    Since we do have to manually add every upcoming PHP version, adding that version to this list might be possible as well.
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    2e6bc45 View commit details
    Browse the repository at this point in the history
  30. qa: normalize continuous-integration.yml

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    9ad85b9 View commit details
    Browse the repository at this point in the history
  31. qa: disable @typescript-eslint/no-inferrable-types as we stricter i…

    …s better
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    a3c96a0 View commit details
    Browse the repository at this point in the history
  32. qa: disable object-shorthand check as we do want to be more explicit

    Having "magic" to detect the property name is not really preferred.
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    564297f View commit details
    Browse the repository at this point in the history
  33. qa: optimize eslint and fixed some issues

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    47bcf43 View commit details
    Browse the repository at this point in the history
  34. qa: remove unnecessary annotations

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    d5df1f8 View commit details
    Browse the repository at this point in the history
  35. bugfix: remove possibly unused awesome-typescript-loader

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    20b452c View commit details
    Browse the repository at this point in the history
  36. bugfix: tell docker container within GHA that it is actually a GHA

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    bf0b3ae View commit details
    Browse the repository at this point in the history
  37. bugfix: pass all host environment variables to the container

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    487adaf View commit details
    Browse the repository at this point in the history
  38. enhancement: use GITHUB_ACTIONS environment variable rather than `G…

    …ITHUB_ACTION` while also having `Github` as default action
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    71b77af View commit details
    Browse the repository at this point in the history
  39. docs: add some description on why we do use GITHUB_ACTIONS environm…

    …ent variable
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    1ee4905 View commit details
    Browse the repository at this point in the history
  40. bugfix: remove GITHUB_ACTIONS environment variable from CI as we do…

    … only want to consume that if this action is being used as an action
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    8846628 View commit details
    Browse the repository at this point in the history
  41. bugfix: ensure latest dependencies for projects without `composer.l…

    …ock`
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    99dbef9 View commit details
    Browse the repository at this point in the history
  42. bugfix: No checks check always contains static locked

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    e6c66e9 View commit details
    Browse the repository at this point in the history
  43. qa: add integration test for project with composer.lock

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    65e619d View commit details
    Browse the repository at this point in the history
  44. revert: change back to diff so we get more readable output

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    6ad9784 View commit details
    Browse the repository at this point in the history
  45. feature: add PHP version and composer dependency set to output check …

    …name
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    55b78ce View commit details
    Browse the repository at this point in the history
  46. bugfix: restore initial diff command

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    32be08b View commit details
    Browse the repository at this point in the history
  47. qa: add integration tests for exclude to verify projects can exclud…

    …e in the old way
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    677e816 View commit details
    Browse the repository at this point in the history
  48. qa: rework sanityChecksPassing to do assertions rather than alway…

    …s returning `true`
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    db517d5 View commit details
    Browse the repository at this point in the history
  49. bugfix: remove unnecessary node call from CI as it pollutes the diff

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    b323d65 View commit details
    Browse the repository at this point in the history
  50. qa: remove unnecessary variable REQUIRE_CHECKS=true from `entrypoin…

    …t.sh`
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    deef576 View commit details
    Browse the repository at this point in the history
  51. feature: use webpack.BannerPlugin to add shebang to generated `main…

    ….js`
    
    This `main.js` is now used in the `entrypoint` without prefixing the executable.
    The `main.js` is now also used within the `CI` pipeline to avoid using the `entrypoint.sh` magic which suppresses the `diff` when it is not being detected from the GIT repository
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    5d9ce00 View commit details
    Browse the repository at this point in the history
  52. feature: output files used for generating the configuration via debug

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    90a5198 View commit details
    Browse the repository at this point in the history
  53. qa: create test to verify that we do not run code checks for docs onl…

    …y diffs
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    08430d2 View commit details
    Browse the repository at this point in the history
  54. qa: add test for code checks without linting even tho the markdown fi…

    …le does exist
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    8364da0 View commit details
    Browse the repository at this point in the history
  55. qa: add integration test for .laminas-ci.json change

    This should trigger all checks even tho the diff contains nothing else.
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    1c2d551 View commit details
    Browse the repository at this point in the history
  56. qa: ensure that we do not run any check if non-PHP and non-markdown f…

    …iles are changed
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f06c9f2 View commit details
    Browse the repository at this point in the history
  57. bugfix: use more readable length check

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    636648f View commit details
    Browse the repository at this point in the history
  58. bugfix: do not run docker with -t since we are not in a TTY

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    6ff3cb8 View commit details
    Browse the repository at this point in the history
  59. bugfix: show proper step name within job

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    4e56746 View commit details
    Browse the repository at this point in the history
  60. bugfix: add backwards compatibility for old job exclusions

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    b5afb6d View commit details
    Browse the repository at this point in the history
  61. docs: update exclude examples to reflect latest changes

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f347807 View commit details
    Browse the repository at this point in the history
  62. qa: enhance deprecated exclusion test

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    4e524e5 View commit details
    Browse the repository at this point in the history
  63. qa: enhance exclusion test

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    ea158df View commit details
    Browse the repository at this point in the history
  64. bugfix: fix tool name in expected matrix output

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    49120eb View commit details
    Browse the repository at this point in the history
  65. bugfix: ensure that job definitions are always created via createJob

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    41ebcfa View commit details
    Browse the repository at this point in the history
  66. qa: we should expect latest in projects without composer.lock

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    73bc9c3 View commit details
    Browse the repository at this point in the history
  67. bugfix: ensure that expected matrix is generated as expected by addin…

    …g `composer.json` and `composer.lock`
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    c7439e2 View commit details
    Browse the repository at this point in the history
  68. bugfix: initialize variable before pushing

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    ff69543 View commit details
    Browse the repository at this point in the history
  69. bugfix: No checks check will not provide PHP or composer dependency…

    … set
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    124c789 View commit details
    Browse the repository at this point in the history
  70. bugfix: ensure tests properly reflect what we do want to verify

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    5871d45 View commit details
    Browse the repository at this point in the history
  71. bugfix: ensure backwards compatibility for deprecated exclusions

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    227a98e View commit details
    Browse the repository at this point in the history
  72. bugfix: provide tool information via job to provide backwards compati…

    …bility
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    b1737c8 View commit details
    Browse the repository at this point in the history
  73. bugfix: properly detected @latest and @lowest from job definition…

    … for PHP versions
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    450e390 View commit details
    Browse the repository at this point in the history
  74. qa: ensure line-length is not exceeded

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    cbd2a8f View commit details
    Browse the repository at this point in the history
  75. bugfix: we do have locked dependencies and thus we should expect `l…

    …ocked` dependencies here
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    b66d3b1 View commit details
    Browse the repository at this point in the history
  76. bugfix: wrap ternary operation in brackets

    I am not 100% sure what is happening here, but somehow, if the ternary operator is not wrapped in brackets, the null-safe operator does work as expected and the value of the ternary operation is being used instead
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f794686 View commit details
    Browse the repository at this point in the history
  77. qa: expected output should not double quote the job

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    972aa8d View commit details
    Browse the repository at this point in the history
  78. bugfix: since no composer.lock is available, we do expect latest

    …rather than `locked`
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    7f9306f View commit details
    Browse the repository at this point in the history
  79. bugfix: PHP 8.0 platform requirements are not ignored by default anymore

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    c9676b4 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. bugfix: ensure we properly validate the .laminas-ci.json with the `…

    …laminas-ci.schema.json`
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    ad517a1 View commit details
    Browse the repository at this point in the history
  2. bugfix: allow @lowest and @latest for php information within th…

    …e `.laminas-ci.json`
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    f089a42 View commit details
    Browse the repository at this point in the history
  3. bugfix: use proper composer.schema.json name

    This also adds an action failure to whenever a schema could not be detected.
    
    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    081d677 View commit details
    Browse the repository at this point in the history
  4. qa: normalize line endings

    Signed-off-by: Maximilian Bösing <[email protected]>
    boesing committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    6733c63 View commit details
    Browse the repository at this point in the history