-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support schedule
event for GitHub Actions
#92
Support schedule
event for GitHub Actions
#92
Conversation
Signed-off-by: Nathanael Esayeas <[email protected]>
closed, due to inactive maintainers.
Time to re-invent the wheel. |
I'm sorry if your schedule does not match our IRL ones, but this is not the way to communicate with other volunteers. In addition to that, we discussed this on slack: @boesing's work needs to take precedence here, as it is about mostly rewriting these components. This is not the right attitude: it is detrimental to general morale, and doesn't help anybody at all, other than making yourself look like somebody that doesn't understand that shit happens outside your sphere of influence. As much as I appreciate your help in getting loads of upgrades introduced in the various laminas repositories in the past few months, this sort of communication only drives people away, and erodes at mutual trust. Personally, I'll probably refrain from actively helping you, if what comes back is a slap in the face telling me that my decade-long maintenance efforts, constrained by "needing to do stuff outside OSS", are "not enough": it's simply not worth my mental energy. |
I communicated via slack, and requested for someone to review two very small PRs, 1 Line Of Code and 4 Lines Of Code. (I was told to wait for laminas/laminas-ci-matrix-action#62)
Correct, but both PRs are still incomplete/drafts, which will require more time to complete. laminas/laminas-ci-matrix-action#62 laminas/laminas-ci-matrix-action#83 It became apparent that until those PRs are merged, my PRs will not be reviewed so I merged the PRs on my fork repo instead and closed this.
No, I simply decided to fork the Repos and merge my changes on the forks instead. Because the changes I was introducing were a total of 6 LOC, @boesing could include this in his work and I would not have to wait anymore because I have my forked repo
I'm always happy to help, and that's never going to change.
I disagree, my intent was to close the PR and provide my (factual) reasoning. You choose to take it as a personal attack. I respect your opinion that "this sort of communication only drives people away, and erodes at mutual trust"…. Why can't you respect my opinion that "Constantly having to request for review because PRs are ignored is very discouraging and would drive away contributors."
I don’t understand why you seem to think this is a personal attack. I have always been respectful, and that's not going to change. I have never forced you or anyone else to help me. In fact, I have been helping others in slack, a lot more than I've asked questions. Each time you've helped me, I've thanked you for taking the time out of your busy life to answer my question. Going forward, I'll respect your wishes and I will refrain from asking you anything if that's what you want. Thank you for all the contributions you've made, thank you for the few times you've answered my questions, and thank you for being open with me here. An excerpt from “Best Practices for Reviewing Pull Requests in GitHub” - https://rewind.com/blog/best-practices-for-reviewing-pull-requests-in-github/
Needless to say, I harbor no ill will towards you or anyone. I will continue to contribute to laminas and mezzio, unless instructed otherwise. I have no intention of forcing my views or opinions on anyone. In closing: If you have too much work on your plate, as an OSS Maintainer, pass the workload to other developers who are willing and able, like me, so you can focus on what matters to you (which should reduce your obligations to just reviewing & merging PRs). Leaving all of these Issues & PRs open is only adding to your workload and slowing down, if not halting, everyone's development process. |
No, you decided to close after stating that we are "ignoring you" and that we are "wasting your time". There is no need to drag this further: locking here for the sake of everyone that would otherwise have to deal with your abrasive communication style. |
Description
schedule
schedule
event for GitHub Actions laminas-ci-matrix-action#88