JobSink: Delete secrets associated with jobs when jobs are deleted

[pierDipi]

As reported in #8323 old
JobSink secrets lead to processing old events again while new events
are lost, even though this should not happen because distinct events
must have different id or source, it's a valid issue as it leaves orphan
secrets.

Using OwnerReference and k8s garbage collection, now a secret created
for a given event is bound to a given Job lifecycle, so that when a job is
deleted, the associated secret will be deleted.

Fixes #8323

Proposed Changes

• JobSink: Delete secrets associated with jobs when jobs are deleted
• Create Job before Secret to bind the secret to the Job lifecycle via owner reference

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

JobSink: bind secrets lifecycle to associated jobs lifecycle. Using OwnerReference and k8s garbage collection, now a secret created for a given event is bound to a given Job lifecycle, so that when a job is deleted, the associated secret will be deleted.

Docs

[codecov]

Codecov Report

Attention: Patch coverage is 4.34783% with 66 lines in your changes missing coverage. Please review.

Project coverage is 64.58%. Comparing base (bc6e878) to head (97acec1).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/jobsink/main.go	4.34%	66 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8331      +/-   ##
==========================================
- Coverage   64.58%   64.58%   -0.01%     
==========================================
  Files         373      373              
  Lines       22619    22666      +47     
==========================================
+ Hits        14609    14639      +30     
- Misses       7244     7260      +16     
- Partials      766      767       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[pierDipi]

/test unit-tests

[pierDipi]

/cc @creydr @matzew

[pierDipi]

/cherry-pick release-1.16

[pierDipi]

/cherry-pick release-1.15

[knative-prow-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[matzew]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matzew,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@pierDipi: new pull request created: #8332

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow-robot]

@pierDipi: new pull request created: #8333

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.