Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobSink: Delete secrets associated with jobs when jobs are deleted #8331

Merged
merged 4 commits into from
Nov 19, 2024

Commits on Nov 18, 2024

  1. JobSink: Delete secrets associated with jobs when jobs are deleted

    As reported in knative#8323 old
    JobSink secrets lead to processing old events again while new events
    are lost.
    
    Using OwnerReference and k8s garbage collection, now a secret created
    for a given event is bound to a given Job lifecycle, so that when a job
    is deleted, the associated secret will be deleted.
    
    Signed-off-by: Pierangelo Di Pilato <[email protected]>
    pierDipi committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    c9fc3cf View commit details
    Browse the repository at this point in the history
  2. Fix jobsink name generator + add unit and fuzz tests

    Signed-off-by: Pierangelo Di Pilato <[email protected]>
    pierDipi committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4694fb7 View commit details
    Browse the repository at this point in the history
  3. Fix e2e test

    Signed-off-by: Pierangelo Di Pilato <[email protected]>
    pierDipi committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5f0617d View commit details
    Browse the repository at this point in the history
  4. Lint

    Signed-off-by: Pierangelo Di Pilato <[email protected]>
    pierDipi committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    97acec1 View commit details
    Browse the repository at this point in the history