Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.15] JobSink: Delete secrets associated with jobs when jobs are deleted #8333

Merged
merged 5 commits into from
Nov 19, 2024
Merged

[release-1.15] JobSink: Delete secrets associated with jobs when jobs are deleted #8333

merged 5 commits into from
Nov 19, 2024
+251 −56

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #8331

JobSink: bind secrets lifecycle to associated jobs lifecycle. Using OwnerReference and k8s garbage collection, now a secret created for a given event is bound to a given Job lifecycle, so that when a job is deleted, the associated secret will be deleted.

@pierDipi @knative-prow-robot
JobSink: Delete secrets associated with jobs when jobs are deleted
4fb3666 
As reported in knative#8323 old
JobSink secrets lead to processing old events again while new events
are lost.

Using OwnerReference and k8s garbage collection, now a secret created
for a given event is bound to a given Job lifecycle, so that when a job
is deleted, the associated secret will be deleted.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi @knative-prow-robot
Fix jobsink name generator + add unit and fuzz tests
317556d 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi @knative-prow-robot
Fix e2e test
0fe3ad2 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi @knative-prow-robot
Lint
8fe666d 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow-robot knative-prow-robot mentioned this pull request Nov 19, 2024
Merged
5 tasks
@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Nov 19, 2024
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 19, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.34783% with 66 lines in your changes missing coverage. Please review.

Project coverage is 66.40%. Comparing base (e32831a) to head (44f08d2).
Report is 1 commits behind head on release-1.15.

Files with missing lines Patch % Lines
cmd/jobsink/main.go 4.34% 66 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.15    #8333      +/-   ##
================================================
- Coverage         66.44%   66.40%   -0.04%     
================================================
  Files               356      356              
  Lines             21103    21120      +17     
================================================
+ Hits              14022    14025       +3     
- Misses             6363     6377      +14     
  Partials            718      718

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

matzew
matzew approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 19, 2024
@matzew
Copy link
Member

matzew commented Nov 19, 2024

/retest

1 similar comment
@matzew
Copy link
Member

matzew commented Nov 19, 2024

/retest

@matzew
add missing import
44f08d2 
Signed-off-by: Matthias Wessendorf <[email protected]>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
matzew
matzew approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Nov 19, 2024

@pierDipi for some reason, an import seemed to be missing in this automated cherry-pick. Added it

@knative-prow knative-prow bot merged commit 62cce11 into knative:release-1.15 Nov 19, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knative-prow-robot @matzew @pierDipi