feat: add an option to ignore sync of quote tweets #18
Conversation
Signed-off-by: Miroslav Bajtoš <[email protected]>
- Replace the global constant `DEFAULT_SYNC_OPTIONS` with a factory function to obtain a new instance of the options object - Rework tests using custom options to start with the default options and modify only the fields relevant in the test. With this improvement in place, when we add a new sync option in the future, existing tests should not need any changes. Signed-off-by: Miroslav Bajtoš <[email protected]>
|
I noticed that adding a new sync option is more involved than I'd like to - I had to update many existing tests to provide value for the new option, despite the fact that the new flag is not relevant for those tests. To address this issue and improve the situation for the future, I added a new commit f545072 to rework the way how we are building options in |
|
Hm, is disabling quote tweets completely an option many users would want? I think you just want the old behavior back where we embed the tweet link instead of quoted text? Then I think it would make more sense to close this and work on that option. What would we call that option? |
That's a good question. I though that if somebody does not want to sync retweets, then perhaps they may want an option to disable syncing quoted tweets too? Maybe not 🤷
Yes, that's the behavior I am ultimately looking for.
Sure, makes sense. Let's discuss the details in #17 then. |
This is a follow-up for our dicussion in #14. As a short-term solution, until we figure out a better solution in #17, I am proposing to add a new option to disable syncing of quote tweets entirely.
sync_quote_tweetstrue(to preserve backwards compatibility)