refactor: simplify building of options in tests #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
commented
May 7, 2020
| sync_retweets: true, | ||
| }; | ||
| let mut options = get_sync_options(); | ||
| options.sync_reblogs = false; |
There was a problem hiding this comment.
An alternative I considered: Instead of changing all tests to use get_sync_options() instead of DEFAULT_SYNC_OPTIONS, maybe I can instead use clone only in the tests that need to modify the default values. Something along the following lines:
let mut options = DEFAULT_SYNC_OPTIONS.clone();
options.sync_reblogs = false;What do you think?
There was a problem hiding this comment.
I went ahead and implemented this simpler version. The patch is much smaller now 🕺
Rework tests using custom options to clone the default options and modify only the fields relevant in the test. With this improvement in place, when we add a new sync option in the future, existing tests should not need any changes. Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
force-pushed
the
refactor/simplify-tests
branch
from
d917c91
to
b771dc8
Compare
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #18, where I noticed that adding a new sync option involves changes in many existing tests, which is not ideal.
DEFAULT_SYNC_OPTIONSwith a factory function to obtain a new instance of the options objectWith this improvement in place, when we add a new sync option in the future, existing tests should not need any changes.