Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable handling of quote tweets #17

Open
bajtos opened this issue May 2, 2020 · 4 comments
Open

Configurable handling of quote tweets #17

bajtos opened this issue May 2, 2020 · 4 comments

Comments

@bajtos
Copy link
Contributor

bajtos commented May 2, 2020

The issue #16 proposed to include the full text of the quoted tweet in the Mastodon post, the feature was implemented by 41946d1 and following commits.

In #14, I proposed a different handling of quote tweets:

  1. The toot contains only the text I wrote in my tweet.
  2. The toot links to the quoted status (tweet)

Consider the following quote tweet: https://twitter.com/bajtos/status/1252469674681544704

At the moment, cargo run -- -n prints the following item:

Posting to Mastodon: LoopBack 4 depends on AJV to perform validations too! Please consider supporting AJV maintenance and development by a donation 🙏 Every little helps!

QT fastifyjs: If you can validate requests in Fastify is thanks to this fantastic project, who is now asking for support.
If you would like to make a donation, please consider it :)
https://github.com/epoberezkin/ajv#please-sponsor-ajv
#opensource #sustainability

What I would like to see instead (conceptually, I am not sure how attachments/links work in Mastodon):

Posting to Mastodon: LoopBack 4 depends on AJV to perform validations too! Please consider supporting AJV maintenance and development by a donation 🙏 Every little helps!
https://twitter.com/fastifyjs/status/1252343103958118402

Can we find a good way how to make this behavior configurable by the user?

@bajtos
Copy link
Contributor Author

bajtos commented May 2, 2020

An edge case to consider:

When quoting my own tweet that was synced to Mastodon, the post for the quote tweet should link to the Mastodon post, not the original Twitter post. Example: https://twitter.com/bajtos/status/1255759378424254465

@bajtos
Copy link
Contributor Author

bajtos commented May 4, 2020

Continuing the discussion from #18:

What would we call that option? embed_quote_tweets = true? Then you could set that option to false to have tweet links again.

Maybe embed_quoted_tweets, because the option is controlling what happens to the text of the quoted tweet (e.g. the target status), not the quote tweet (the retweet-like status).

@klausi
Copy link
Owner

klausi commented May 4, 2020

yep, embed_quoted_tweets sounds good!

should it be an option under Mastodon or Twitter? I'm thinking Mastodon because that is where the embedding happens?

@defaultxr
Copy link

Just to chime in regarding the feature suggested in #18 (since this seems to be the issue for it now) - I personally would want an option to disable syncing quote tweets entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants