-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OperationSpaceController
to docs and tests
#879
Conversation
OperationSpaceControl
to docs and testsOperationSpaceController
to docs and tests
@jtigue-bdai, shall we also include in this PR, adding a corresponding action class, i.e., OperationSpaceControllerAction/Cfg, here? This would be nice for being able to interface it with the action manager, and such exist for other controllers. |
Yeah I think that would be a good addition with this effort. |
@jtigue-bdai At the moment I do not have push access to this PR branch. Would you prefer I create a new PR from my own fork to integrate into this PR (so there would be two different PRs for the same topic), or would you like to give me push access to this branch? If you will give access, could you do it for both @ozhanozen and @sbtc-sipbb? |
Sorry @ozhanozen my intention was for you to push to this branch, but let me check with the dev team this morning and I will get back to you. |
@ozhanozen I talked with the team. Because this repo is setup within the isaac-sim org, the best way moving forward will be to have you create the PR from your fork and to the isaac-sim/isaac-lab. We can then just close this one and I can give you reviews you your branch. Sorry for the confusion, I didn't realize some of the restrictions we had setup. |
@jtigue-bdai no problem. I have created a new PR from my fork, #913, as you suggested, and we can work on it. You can close this PR. |
Closing in favor of #913 for OS user contributions |
Description
This PR add the
OperationSpaceController
to the docs and provides some test for its parameteric features.Fixes #873
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there