Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CODEOWNERS file to streamline notifications #807

Merged
merged 10 commits into from
Aug 24, 2024

Conversation

jsmith-bdai
Copy link
Collaborator

@jsmith-bdai jsmith-bdai commented Aug 8, 2024

Description

This PR adds in a CODEOWNERS file so that we can better handle the review request process.

NOTE: This version is not finalized, please add suggestions to other areas on this PR. We can constantly add more as well, I just wanted to get an initial version up and filled in the things I knew off the top of my head 😄

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@pascal-roth
Copy link
Collaborator

Looks like a cool feature to me! I would personally do not include teams as there might be a lot of changes within the people. But that can be up for discussion

.github/CODEOWNERS Outdated Show resolved Hide resolved
@jsmith-bdai
Copy link
Collaborator Author

Looks like a cool feature to me! I would personally do not include teams as there might be a lot of changes within the people. But that can be up for discussion

@pascal-roth Thanks! Please add any section of the code for which you would like to be a reviewer for as suggestions

@Mayankm96 Mayankm96 changed the title Add CODEOWNERS file with a few examples Adds CODEOWNERS file with current developer team Aug 23, 2024
@Mayankm96
Copy link
Contributor

@jsmith-bdai I took a stab at having a more thorough listing in there. Still a pretty tentative list. We can work on improving it in our discussions.

@Mayankm96 Mayankm96 added the enhancement New feature or request label Aug 23, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Collaborator

@jtigue-bdai jtigue-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions for some areas of interest for me.

Mayankm96 and others added 3 commits August 24, 2024 11:10
Co-authored-by: James Smith <[email protected]>
Co-authored-by: jtigue-bdai <[email protected]>
Signed-off-by: Mayank Mittal <[email protected]>
@Mayankm96 Mayankm96 changed the title Adds CODEOWNERS file with current developer team Adds CODEOWNERS file to streamline notifications Aug 24, 2024
@Mayankm96 Mayankm96 merged commit df184e1 into main Aug 24, 2024
2 of 3 checks passed
@Mayankm96 Mayankm96 deleted the feature/add_codeowners branch August 24, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants