Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes setting of pose when spawning a mesh #692

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Fixes setting of pose when spawning a mesh #692

merged 4 commits into from
Aug 2, 2024

Conversation

masoudmoghani
Copy link
Collaborator

@masoudmoghani masoudmoghani commented Jul 16, 2024

Description

This MR removes the additional translation and orientation applied when creating the mesh prim under the parent Xform prim.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Mayankm96 Mayankm96 changed the title Fixes meshes Fixes setting of pose when spawning a mesh Aug 2, 2024
@Mayankm96 Mayankm96 added the bug Something isn't working label Aug 2, 2024
@Mayankm96 Mayankm96 merged commit a599cb2 into main Aug 2, 2024
2 of 3 checks passed
@Mayankm96 Mayankm96 deleted the fix/meshes branch August 2, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants