Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes docstring in reward functions and code block in documentation #661

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

fan-ziqi
Copy link
Contributor

@fan-ziqi fan-ziqi commented Jul 9, 2024

Description

Fixes docstring in reward functions and code block in documentation

Type of change

  • Bug fix

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Dhoeller19 Dhoeller19 changed the title Fixes some doc issues Fixes docstring in reward function and code block in documentation Jul 17, 2024
@Dhoeller19 Dhoeller19 self-requested a review July 17, 2024 12:11
@Dhoeller19 Dhoeller19 changed the title Fixes docstring in reward function and code block in documentation Fixes docstring in reward functions and code block in documentation Jul 17, 2024
@Dhoeller19 Dhoeller19 merged commit 36e3abf into isaac-sim:main Jul 17, 2024
1 of 2 checks passed
fatimaanes pushed a commit to fatimaanes/omniperf that referenced this pull request Aug 8, 2024
…saac-sim#661)

# Description

Fixes docstring in reward functions and code block in documentation

## Type of change

- Bug fix

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants