Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes conda installation using isaaclab.sh script #651

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

Dhoeller19
Copy link
Collaborator

@Dhoeller19 Dhoeller19 commented Jul 6, 2024

Description

Fixes Isaac Lab conda installation

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Dhoeller19 Dhoeller19 requested a review from Mayankm96 July 6, 2024 11:35
@Mayankm96 Mayankm96 changed the title Fixes Isaac Lab conda installation Fixes conda installation using isaaclab.sh script Jul 6, 2024
@Mayankm96 Mayankm96 added the bug Something isn't working label Jul 6, 2024
Copy link
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@Mayankm96 Mayankm96 merged commit b1be6bb into main Jul 6, 2024
3 checks passed
@Mayankm96 Mayankm96 deleted the fix/installation branch July 6, 2024 15:53
mohanksriram pushed a commit to mohanksriram/IsaacLab that referenced this pull request Jul 12, 2024
# Description

Fixes Isaac Lab conda installation  

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants