Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable composite compose #455

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

farbod-farshidian
Copy link
Collaborator

Description

This PR updates the container.sh script to support the creation of composite Compose files. By allowing external docker-compose and environment files to be provided to the Compose command, users can utilize both the Merge and Extend strategies.

Example for Merge: Users can supply a new .env file to override the DOCKER_ISAACLAB_PATH variable in the base Docker configuration.
Example for Extend: Users can provide external docker-compose and env files to extend the base service.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run all the tests with ./isaaclab.sh --test and they pass
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Base automatically changed from fix/docker_hardcoded_path to main June 4, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant