-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Reverts URDF importer to 2.4.24 to continue support for merge-joints #4000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummaryThis PR reverts the URDF importer extension to version 2.4.24 to restore merge-joints functionality that was removed in Isaac Sim 5.1. The changes systematically update all references to use the versioned extension name. Key Changes:
Technical Correctness: Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant UrdfConverter
participant ExtensionManager
participant UrdfImporter_2_4_24 as URDF Importer v2.4.24
participant IsaacSim
User->>UrdfConverter: Convert URDF with merge_fixed_joints=true
UrdfConverter->>ExtensionManager: Check if extension enabled
ExtensionManager-->>UrdfConverter: Extension status
UrdfConverter->>ExtensionManager: enable_extension("isaacsim.asset.importer.urdf-2.4.24")
ExtensionManager->>UrdfImporter_2_4_24: Load extension v2.4.24
UrdfImporter_2_4_24-->>ExtensionManager: Extension loaded
UrdfConverter->>UrdfImporter_2_4_24: acquire_urdf_interface()
UrdfImporter_2_4_24-->>UrdfConverter: URDF interface
UrdfConverter->>UrdfConverter: _get_urdf_import_config()
Note over UrdfConverter: Set merge_fixed_joints=true
UrdfConverter->>IsaacSim: URDFParseFile command
IsaacSim-->>UrdfConverter: Parsed robot model
UrdfConverter->>IsaacSim: URDFImportRobot command
Note over IsaacSim: Merges fixed joints using v2.4.24 logic
IsaacSim-->>UrdfConverter: USD file with merged joints
UrdfConverter-->>User: Conversion complete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 files reviewed, no comments
|
That change results in wrongly oriented visuals in the exported USD |
|
@Passutte can you share more on the issues you are seeing? is that in particular with the 2.4.24 version of the importer and fixed on the latest? |
E.g., when using the ANYmal urdf from https://github.com/ANYbotics/anymal_d_simple_description - with the default importer ANYmal looks fine. However, the merge joints functionality does not work. Now, with this fix the merge joints functionality works, but the visuals are all wrong. The collision bodies look fine. |
| # Isaac Sim Extra | ||
| "isaacsim.asset.importer.mjcf" = {} | ||
| "isaacsim.asset.importer.urdf" = {} | ||
| "isaacsim.asset.importer.urdf" = {version = "2.4.24", exact = true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably need to do it here as well: https://github.com/isaac-sim/IsaacLab/blob/main/source/isaaclab/isaaclab/sim/converters/urdf_converter.py#L50-L51


Description
Latest URDF importer in Isaac Sim 5.1 removed the support for merge-joints, which caused a breaking change for some users. Although this will maintain as the behavior going forward, we are reverting back to an older version of the URDF importer for the short term that still provides the merge-joints support.
In the future, we will look into providing more tooling for supporting similar behaviors in addition to the importer itself.
Fixes #3943
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there