-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Unify Isaac Lab assets with Isaac Sim #3608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
How was the asset verification done? Did you run training on a proper set of environments and made sure they all train exactly the same? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concerns with how asset generation was done and verifed. This is a big change.
Matthew helped me verify all these assets using a benchmark with 2 main metrics: rewards and duration. We verified that all the tasks have similar metrics as before @matthewtrepte to provide more details as well |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there