Skip to content

Conversation

stevfeng
Copy link

@stevfeng stevfeng commented Oct 2, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added asset New asset feature or request isaac-sim Related to Isaac Sim team labels Oct 2, 2025
@stevfeng stevfeng requested a review from matthewtrepte October 2, 2025 18:32
@Mayankm96
Copy link
Contributor

How was the asset verification done? Did you run training on a proper set of environments and made sure they all train exactly the same?

Copy link
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerns with how asset generation was done and verifed. This is a big change.

@stevfeng
Copy link
Author

stevfeng commented Oct 7, 2025

Concerns with how asset generation was done and verifed. This is a big change.

How was the asset verification done? Did you run training on a proper set of environments and made sure they all train exactly the same?

Matthew helped me verify all these assets using a benchmark with 2 main metrics: rewards and duration. We verified that all the tasks have similar metrics as before

@matthewtrepte to provide more details as well

@stevfeng stevfeng requested a review from Mayankm96 October 7, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset New asset feature or request isaac-sim Related to Isaac Sim team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants