Skip to content

Conversation

cathyliyuanchen
Copy link
Contributor

Description

Adding auto-calibration of the scaling factor param in retargeter, according to human hand length from the hand poses. The robot pinky curls on its own if the scaling factor is too small, and the index finger have trouble curling if the scaling factor is too large, but "small/large" depend on the hand size.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Before After

|
Screenshot from 2025-07-30 15-53-42
|
Screenshot from 2025-07-30 15-54-32
|

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there
    -->

@github-actions github-actions bot added isaac-mimic Related to Isaac Mimic team isaac-lab Related to Isaac Lab team labels Sep 26, 2025
Copy link
Collaborator

@ooctipus ooctipus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, there is no issue from formatting.

I am a bit concerning that editing so many files to introduce a flag seems a bit extra, I would suggest have one more mimic engineer to take a look and judge what could be the best way to introduce them before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
isaac-lab Related to Isaac Lab team isaac-mimic Related to Isaac Mimic team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants