Fixes various typos in the documentation #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix typo: "For completion" with "For completeness" - fix typo: reset - fix typo: blocks - fix `--checkpoint` docs - better phrasing about --checkpoint - add my name to CONTRIBUTORS.md - fix typo: remove "is"
Mayankm96
changed the title
Mayankm96
reviewed
Mar 22, 2024
Mayankm96
reviewed
Mar 22, 2024
Mayankm96
requested changes
Mar 22, 2024
|
Sorry if something is wrong - my knowledge stops at this point. |
|
No worries. If you remove the checkpoint loading changes, we can look into clarifying that part from our side. Thanks! |
Mayankm96
force-pushed
the
main
branch
3 times, most recently
from
3e7a470
to
cfcabba
Compare
Signed-off-by: Mayank Mittal <[email protected]>
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
## Description This MR improves the documentation: - fix typo: "For completion" with "For completeness" - fix typo: reset - fix typo: blocks - fix typo: remove "is" Fixes isaac-sim#302, isaac-sim#303, isaac-sim#304 ## Type of change - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #302, #303, #304
This PR is a squash of these previous pull requests:
#310, #311, #312, #315
Type of change
Checklist
pre-commitchecks with./orbit.sh --format./orbit.sh --testand they passconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there