-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes various typos in the documentation #321
Conversation
- fix typo: "For completion" with "For completeness" - fix typo: reset - fix typo: blocks - fix `--checkpoint` docs - better phrasing about --checkpoint - add my name to CONTRIBUTORS.md - fix typo: remove "is"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkpoint loading still seems not the clearest to me after your changes.
Sorry if something is wrong - my knowledge stops at this point. |
No worries. If you remove the checkpoint loading changes, we can look into clarifying that part from our side. Thanks! |
3e7a470
to
cfcabba
Compare
Signed-off-by: Mayank Mittal <[email protected]>
## Description This MR improves the documentation: - fix typo: "For completion" with "For completeness" - fix typo: reset - fix typo: blocks - fix typo: remove "is" Fixes isaac-sim#302, isaac-sim#303, isaac-sim#304 ## Type of change - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Description
Fixes #302, #303, #304
This PR is a squash of these previous pull requests:
#310, #311, #312, #315
Type of change
Checklist
pre-commit
checks with./orbit.sh --format
./orbit.sh --test
and they passconfig/extension.toml
fileCONTRIBUTORS.md
or my name already exists there