Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds configuration classes for spawning different assets at prim paths #1164

Merged
merged 31 commits into from
Oct 9, 2024

Conversation

Mayankm96
Copy link
Contributor

Description

This MR adds configuration classes that allow spawning different assets at the resolved prim paths. For instance, for the prim path expression "/World/envs/env_.*/Object", these configuration instances allow spawning a different type of prim at individual path locations.

Fixes #186

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Mayankm96 Mayankm96 added the enhancement New feature or request label Oct 7, 2024
@Mayankm96 Mayankm96 self-assigned this Oct 7, 2024
Copy link
Collaborator

@jtigue-bdai jtigue-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor docstring stuff. LGTM

Mayankm96 and others added 3 commits October 9, 2024 08:57
Co-authored-by: jtigue-bdai <[email protected]>
Signed-off-by: Mayank Mittal <[email protected]>
Co-authored-by: jtigue-bdai <[email protected]>
Signed-off-by: Mayank Mittal <[email protected]>
Copy link
Collaborator

@renezurbruegg renezurbruegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for implementing this!

In my experience, spawning multiple can lead to quite some issues when replicate physics is set to true, especially if additional randomization are applied. Could be helpful to add a check if replicate physics is set and a MultiAsset spawner is used, and if yes, print a warning?

@Mayankm96
Copy link
Contributor Author

Thanks a lot for implementing this!

In my experience, spawning multiple can lead to quite some issues when replicate physics is set to true, especially if additional randomization are applied. Could be helpful to add a check if replicate physics is set and a MultiAsset spawner is used, and if yes, print a warning?

@Dhoeller19 What do you think? I added a note in the how-to but of course not the best (since many might miss it).

One solution could be: We set a carb flag that multiple assets were spawned (the flag is set inside the spawner function). And then in the environment we check if this flag is True and replicate physics is True, and throw a warning accordingly?

@Mayankm96
Copy link
Contributor Author

@renezurbruegg @Dhoeller19 Added a check inside InteractiveScene.

@Mayankm96 Mayankm96 merged commit f6741f3 into main Oct 9, 2024
3 checks passed
@Mayankm96 Mayankm96 deleted the feature/multi-object branch October 9, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Spawn different asset in different environment
4 participants