-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds configuration classes for spawning different assets at prim paths #1164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor docstring stuff. LGTM
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/wrappers/wrappers.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/wrappers/wrappers.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/wrappers/wrappers.py
Outdated
Show resolved
Hide resolved
Co-authored-by: jtigue-bdai <[email protected]> Signed-off-by: Mayank Mittal <[email protected]>
Co-authored-by: jtigue-bdai <[email protected]> Signed-off-by: Mayank Mittal <[email protected]>
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/wrappers/wrappers.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/wrappers/wrappers.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Mayank Mittal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for implementing this!
In my experience, spawning multiple can lead to quite some issues when replicate physics is set to true, especially if additional randomization are applied. Could be helpful to add a check if replicate physics is set and a MultiAsset spawner is used, and if yes, print a warning?
@Dhoeller19 What do you think? I added a note in the how-to but of course not the best (since many might miss it). One solution could be: We set a carb flag that multiple assets were spawned (the flag is set inside the spawner function). And then in the environment we check if this flag is True and replicate physics is True, and throw a warning accordingly? |
@renezurbruegg @Dhoeller19 Added a check inside InteractiveScene. |
Description
This MR adds configuration classes that allow spawning different assets at the resolved prim paths. For instance, for the prim path expression "/World/envs/env_.*/Object", these configuration instances allow spawning a different type of prim at individual path locations.
Fixes #186
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there