Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert groovy tests to ScalaTest, remove groovy #646

Open
sebastian-peter opened this issue Nov 7, 2023 Discussed in #645 · 4 comments · Fixed by #773, #831, #832, #839 or #840
Open

Convert groovy tests to ScalaTest, remove groovy #646

sebastian-peter opened this issue Nov 7, 2023 Discussed in #645 · 4 comments · Fixed by #773, #831, #832, #839 or #840
Assignees
@pierrepetersmeier
Labels
code quality Code readability or efficiency is improved test Issues related to (unit) tests
Milestone
Version 4.0

Comments

@sebastian-peter
Copy link
Member

Convert all groovy tests to ScalaTest, then remove everything related to groovy:

  • dependencies (spock, ...)
  • compile steps, if applicable
  • code formatting (spotlessGroovy)
  • ...
@sebastian-peter sebastian-peter added test Issues related to (unit) tests code quality Code readability or efficiency is improved labels Nov 7, 2023
@danielfeismann danielfeismann added the good first issue Good for newcomers label Nov 7, 2023
@SimonHuette SimonHuette mentioned this issue Feb 7, 2024
Merged
sebastian-peter added a commit that referenced this issue Feb 9, 2024
@sebastian-peter
Merge branch 'dev' into sh/#646-rewrite-groovy-test-to-scala-test
a46d189
danielfeismann added a commit that referenced this issue Feb 20, 2024
@danielfeismann
Merge branch 'dev' into sh/#646-rewrite-groovy-test-to-scala-test
d28bb0a
SimonHuette added a commit that referenced this issue Mar 5, 2024
@SimonHuette
Merge branch 'dev' into sh/#646-rewrite-groovy-test-to-scala-test
45b3528
@pierrepetersmeier pierrepetersmeier mentioned this issue Mar 18, 2024
Merged
@pierrepetersmeier pierrepetersmeier linked a pull request Mar 18, 2024 that will close this issue
pp/#646-convert-groovy-tests-to-scalatest #773
Merged
pierrepetersmeier added a commit that referenced this issue Mar 18, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-convert-groovy-tests-to-scalatest
65947e8
pierrepetersmeier added a commit that referenced this issue Mar 21, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-convert-groovy-tests-to-scalatest
fbdacfe
danielfeismann added a commit that referenced this issue Mar 25, 2024
@danielfeismann
Merge branch 'dev' into sh/#646-rewrite-groovy-test-to-scala-test
37f8d8c
danielfeismann added a commit that referenced this issue Apr 2, 2024
@danielfeismann
Merge branch 'dev' into sh/#646-rewrite-groovy-test-to-scala-test
b92ccf0
danielfeismann added a commit that referenced this issue Apr 15, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into sh/#646-rewrite-groovy-test-to-sca…
a64f9ea 
…la-test

# Conflicts:
#	CHANGELOG.md
danielfeismann added a commit that referenced this issue Apr 15, 2024
@danielfeismann
Merge pull request #726 from ie3-institute/sh/#646-rewrite-groovy-tes…
68bcf46 
…t-to-scala-test

Sh/#646 rewrite groovy test to scala test
danielfeismann added a commit that referenced this issue May 31, 2024
@danielfeismann
Merge branch 'dev' into pp/#646-convert-groovy-tests-to-scalatest
74ad862
danielfeismann added a commit that referenced this issue Jun 12, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into pp/#646-convert-groovy-tests-to-sc…
1ad0a86 
…alatest
@pierrepetersmeier pierrepetersmeier mentioned this issue Jun 16, 2024
Merged
@pierrepetersmeier pierrepetersmeier linked a pull request Jun 16, 2024 that will close this issue
FixedLoadModelSpec.scala-convert-groovy-to-scala #831
Merged
@pierrepetersmeier pierrepetersmeier mentioned this issue Jun 17, 2024
Merged
@pierrepetersmeier pierrepetersmeier linked a pull request Jun 17, 2024 that will close this issue
FixedfeedModelSpec-convert-groovy-tests-to-scalatest #832
Merged
pierrepetersmeier added a commit that referenced this issue Jun 26, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-FixedFeedModelSpec.scala-convert-groo…
cccad44 
…vy-tests-to-scalatest
pierrepetersmeier added a commit that referenced this issue Jun 26, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-convert-groovy-tests-to-scalatest-Fix…
d8c9f02 
…edLoadModelTest
pierrepetersmeier added a commit that referenced this issue Jun 26, 2024
@pierrepetersmeier
Merge remote-tracking branch 'origin/pp/#646-FixedFeedModelSpec.scala…
dc764e0 
…-convert-groovy-tests-to-scalatest' into pp/#646-FixedFeedModelSpec.scala-convert-groovy-tests-to-scalatest

# Conflicts:
#	CHANGELOG.md
@pierrepetersmeier pierrepetersmeier mentioned this issue Jun 28, 2024
Merged
@pierrepetersmeier pierrepetersmeier linked a pull request Jun 28, 2024 that will close this issue
Rewrote RefSystemTest from groovy to scala. #839
Merged
danielfeismann added a commit that referenced this issue Jul 1, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into pp/#646-convert-groovy-tests-to-sc…
41b56da 
…alatest

# Conflicts:
#	CHANGELOG.md
@pierrepetersmeier pierrepetersmeier linked a pull request Jul 1, 2024 that will close this issue
Rewrote SystemComponentSpec from groovy to scala #840
Merged
@pierrepetersmeier pierrepetersmeier mentioned this issue Aug 1, 2024
Merged
@pierrepetersmeier pierrepetersmeier linked a pull request Aug 1, 2024 that will close this issue
Rewrote ThermalHouseTest from groovy to scala #877
Merged
pierrepetersmeier added a commit that referenced this issue Aug 6, 2024
@pierrepetersmeier
Merge branch 'refs/heads/df/#872-merge-hp-testdata' into pp/#646-ther…
62b3180 
…mal-convert-groovy-tests-to-scalatest-remove-groovy

# Conflicts:
#	CHANGELOG.md
pierrepetersmeier added a commit that referenced this issue Aug 6, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-thermal-convert-groovy-tests-to-scala…
7bb8d60 
…test-remove-groovy
pierrepetersmeier added a commit that referenced this issue Aug 8, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-thermal-convert-groovy-tests-to-scala…
372e218 
…test-remove-groovy
pierrepetersmeier added a commit that referenced this issue Aug 9, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-thermal-convert-groovy-tests-to-scala…
916241a 
…test-remove-groovy
@danielfeismann danielfeismann removed the good first issue Good for newcomers label Aug 9, 2024
danielfeismann added a commit that referenced this issue Aug 12, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into pp/#646-thermal-convert-groovy-tes…
6e4ae75 
…ts-to-scalatest-remove-groovy

# Conflicts:
#	CHANGELOG.md
danielfeismann added a commit that referenced this issue Aug 12, 2024
@danielfeismann
Merge pull request #877 from ie3-institute/pp/#646-thermal-convert-gr…
24100a7 
…oovy-tests-to-scalatest-remove-groovy

Rewrote ThermalHouseTest from groovy to scala
@pierrepetersmeier pierrepetersmeier mentioned this issue Aug 16, 2024
Merged
@pierrepetersmeier pierrepetersmeier linked a pull request Aug 16, 2024 that will close this issue
bm model test convert groovy tests to scalatest remove groovy #911
Merged
pierrepetersmeier added a commit that referenced this issue Aug 16, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-BMModelTest-convert-groovy-tests-to-s…
231dc39 
…calatest-remove-groovy
pierrepetersmeier added a commit that referenced this issue Aug 22, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-BMModelTest-convert-groovy-tests-to-s…
1b48862 
…calatest-remove-groovy
pierrepetersmeier added a commit that referenced this issue Aug 25, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-BMModelTest-convert-groovy-tests-to-s…
f56640b 
…calatest-remove-groovy
danielfeismann added a commit that referenced this issue Aug 26, 2024
@danielfeismann
Merge pull request #911 from ie3-institute/pp/#646-BMModelTest-conver…
32c4258 
…t-groovy-tests-to-scalatest-remove-groovy

bm model test convert groovy tests to scalatest remove groovy
@sebastian-peter
Copy link
Member Author

Tests that are still open to conversion:

  • ChpModelTest
  • PvModelIT (could be reworked a bit, currently feels a bit "hacky")
  • StorageModelTest
  • SystemParticipantTest
  • CylindricalThermalStorageTest

@pierrepetersmeier
Copy link
Contributor

I'm on it :) It's still a bit buggy here and there. Thanks for the update, it's gotten a little confusing.

@sebastian-peter
Copy link
Member Author

@pierrepetersmeier No worries, just tried to provide an overview for everyone. If you feel like working on something else, just let us know.

@pierrepetersmeier pierrepetersmeier linked a pull request Sep 24, 2024 that will close this issue
Draft
@pierrepetersmeier pierrepetersmeier linked a pull request Sep 24, 2024 that will close this issue
Rewrote ChpModelTest from groovy to scala. #969
Draft
@pierrepetersmeier
Copy link
Contributor

All good, thank you for the update. :)

pierrepetersmeier added a commit that referenced this issue Sep 24, 2024
@pierrepetersmeier
Merge branch 'dev' into PP/#646-convert-ChpModelTest-to-scalatest-rem…
7abdae7 
…ove-groovy
@pierrepetersmeier pierrepetersmeier mentioned this issue Sep 25, 2024
Draft
danielfeismann added a commit that referenced this issue Oct 2, 2024
@danielfeismann
Merge branch 'dev' into pp/#646-convert-SystemParticipantTest-to-scal…
eb5aa07 
…atest-remove-groovy
danielfeismann added a commit that referenced this issue Oct 2, 2024
@danielfeismann
Merge branch 'dev' into PP/#646-convert-SystemParticipantTest-to-scal…
26c7393 
…atest-remove-groovy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierrepetersmeier pierrepetersmeier

Labels
code quality Code readability or efficiency is improved test Issues related to (unit) tests
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging a pull request may close this issue.

pp/#646-CylindricalThermalStorageTest-convert-groovy-tests-to-scalatest-remove-groovy ie3-institute/simona
pp/#646-PvModelIT-convert-groovy-tests-to-scalatest-remove-groovy ie3-institute/simona
pp/#646-convert-groovy-tests-to-scalatest ie3-institute/simona
FixedLoadModelSpec.scala-convert-groovy-to-scala ie3-institute/simona
FixedfeedModelSpec-convert-groovy-tests-to-scalatest ie3-institute/simona
Rewrote RefSystemTest from groovy to scala. ie3-institute/simona
Rewrote SystemComponentSpec from groovy to scala ie3-institute/simona
Rewrote ThermalHouseTest from groovy to scala ie3-institute/simona
bm model test convert groovy tests to scalatest remove groovy ie3-institute/simona
Rewrote ChpModelTest from groovy to scala. ie3-institute/simona
4 participants
@sebastian-peter @danielfeismann @SimonHuette @pierrepetersmeier