Rewrote SystemComponentSpec from groovy to scala #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrepetersmeier
added
code quality
…functional style.
danielfeismann
requested changes
Jul 4, 2024
…a. Delete Model/SystemComponentSpec.scala.
|
Is the simulation start and end time correctly implemented? I'm not sure. The test is now integrated into grid/systemcomponentspec.scala. |
danielfeismann
requested changes
Jul 25, 2024
src/test/scala/edu/ie3/simona/model/grid/SystemComponentSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/grid/SystemComponentSpec.scala
Outdated
Show resolved
Hide resolved
danielfeismann
deleted the
pp/#646-SystemComponentTest-convert-groovy-tests-to-scalatest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SystemComponentTest convert from groovy to scala.
This PR is related to Issue #646