FixedLoadModelSpec.scala-convert-groovy-to-scala #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfeismann
requested changes
Jul 1, 2024
Comment on lines
+37
to
+61
| val loadInput = | ||
| new LoadInput( | ||
| UUID.fromString("4eeaf76a-ec17-4fc3-872d-34b7d6004b03"), | ||
| "testLoad", | ||
| OperatorInput.NO_OPERATOR_ASSIGNED, | ||
| OperationTime.notLimited(), | ||
| new NodeInput( | ||
| UUID.fromString("e5c1cde5-c161-4a4f-997f-fcf31fecbf57"), | ||
| "TestNodeInputModel", | ||
| OperatorInput.NO_OPERATOR_ASSIGNED, | ||
| OperationTime.notLimited(), | ||
| Quantities.getQuantity(1d, PowerSystemUnits.PU), | ||
| false, | ||
| NodeInput.DEFAULT_GEO_POSITION, | ||
| GermanVoltageLevelUtils.LV, | ||
| -1, | ||
| ), | ||
| new CosPhiFixed("cosPhiFixed:{(0.0,0.95)}"), | ||
| null, | ||
| BdewStandardLoadProfile.H0, | ||
| false, | ||
| Quantities.getQuantity(3000d, PowerSystemUnits.KILOWATTHOUR), | ||
| Quantities.getQuantity(282.74d, PowerSystemUnits.VOLTAMPERE), | ||
| 0.95, | ||
| ) |
There was a problem hiding this comment.
I guess this can be simplyfied by using LoadInputTestData. You can access it by extending the class by it.
Comment on lines
+63
to
+72
| val simulationStartDate = | ||
| TimeUtil.withDefaults.toZonedDateTime("2019-01-01T00:00:00Z") | ||
| val simulationEndDate = | ||
| TimeUtil.withDefaults.toZonedDateTime("2019-12-31T23:59:00Z") | ||
| val foreSeenOperationInterval = | ||
| SystemComponent.determineOperationInterval( | ||
| simulationStartDate, | ||
| simulationEndDate, | ||
| loadInput.getOperationTime, | ||
| ) |
There was a problem hiding this comment.
Same here, these are also within DefaultTestData
| forAll(testData) { (reference, expectedPower: Power) => | ||
| val relevantData = FixedLoadModel.FixedLoadRelevantData | ||
|
|
||
| val scale = 1.0 |
There was a problem hiding this comment.
Note to self: scaling 0 - 2.0 needs to be considered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixedLoadModel convert from groovy to scala.
This PR is related to Issue #646