pp/#646-convert-groovy-tests-to-scalatest #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpotlessApply
|
Hey @danielfeismann, i don't know how to proceed with SonarQube and "TOLERANCE" – should it be written in all caps like that? Furthermore, is it okay to make the functions public in the WecModel? Groovy was able to access without error, but Scala tells me that it is unacceptable to access the function if it is private. |
Comment on lines
+136
to
+138
| math.abs( | ||
| result.toWatts - expectedPower.toWatts | ||
| ) should be < powerTolerance.toWatts |
There was a problem hiding this comment.
You can remove the .toWatts here. In combination with shouldBe approximate this should be compared correct in value and unit.
src/test/scala/edu/ie3/simona/model/participant/WecModelSpec.scala
Outdated
Show resolved
Hide resolved
|
!test |
…alatest # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WecModel convert from groovy to scala.
This PR is related to Issue #646