better default display i2c bus

[sensei-hacker]

User description

Uses the external (compass) i2c bus if UG2864_I2C_BUS isn't defined. Otherwise, the default i2c bus.
Rather than i2c1.

---

PR Type

Enhancement

---

Description

This description is generated by an AI tool. It may have inaccuracies

• Improved default I2C bus selection for UG2864 OLED display

• Uses magnetometer I2C bus when available, falls back to default I2C bus

• Replaces hardcoded BUS_I2C1 with more flexible bus selection logic

---

Diagram Walkthrough

flowchart LR
  A["UG2864_I2C_BUS undefined"] --> B["Check MAG_I2C_BUS"]
  B --> C["MAG_I2C_BUS available?"]
  C -->|Yes| D["Use MAG_I2C_BUS"]
  C -->|No| E["Use DEFAULT_I2C_BUS"]
  D --> F["Configure UG2864 display"]
  E --> F

Loading

File Walkthrough

	Relevant files
Enhancement	common_hardware.c Enhanced I2C bus selection logic                                                  src/main/target/common_hardware.c Replaced hardcoded BUS_I2C1 with conditional logic Added fallback hierarchy: MAG_I2C_BUS → DEFAULT_I2C_BUS Improved I2C bus selection for UG2864 OLED display configuration +6/-1

---

[qodo-merge-pro]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
⚪	Build-time config conflict Description: The macro-based fallback may redefine UG2864_I2C_BUS differently across compilation units if headers also define it, potentially causing inconsistent hardware bus selection at build time. common_hardware.c [428-435] Referred Code #if !defined(UG2864_I2C_BUS) #ifdef MAG_I2C_BUS #define UG2864_I2C_BUS MAG_I2C_BUS #else #define UG2864_I2C_BUS DEFAULT_I2C_BUS #endif #endif
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
⚪	No custom compliance provided Follow the guide to enable custom compliance check.

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Add fallback to prevent build failures Add a fallback to BUS_I2C1 for the UG2864_I2C_BUS definition to prevent potential build failures when neither MAG_I2C_BUS nor DEFAULT_I2C_BUS are defined. src/main/target/common_hardware.c [429-430] -#ifdef MAG_I2C_BUS +#if defined(MAG_I2C_BUS) #define UG2864_I2C_BUS MAG_I2C_BUS +#elif defined(DEFAULT_I2C_BUS) + #define UG2864_I2C_BUS DEFAULT_I2C_BUS +#else + #define UG2864_I2C_BUS BUS_I2C1 +#endif Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies a potential build failure if DEFAULT_I2C_BUS is undefined and provides a more robust fallback mechanism, improving the reliability of the configuration.	Medium
More