Repository navigation
Fix audit must-fixes: public donor fields, delete-before-write, index write routes, timeouts - #1052
Merged
Merged
Conversation
NickAkhmetov
commented
Oct 26, 2026
NickAkhmetov
commented
Contributor
- Exclude private Donor fields under "donors" for Samples, Datasets and Publications, and add the donor/origin_samples/source_samples rules for Publications.
- Stop deleting a document before writing its replacement, and raise when a write is rejected instead of logging and continuing.
- Reject PUT /update and POST /add for every index except 'files'.
- Add timeouts to every requests call, and fetch the provenance schema and organ types once per process.
… write routes, timeouts - Exclude private Donor fields under "donors" for Samples, Datasets and Publications, and add the donor/origin_samples/source_samples rules for Publications. - Stop deleting a document before writing its replacement, and raise when a write is rejected instead of logging and continuing. - Reject PUT /update and POST /add for every index except 'files'. - Add timeouts to every requests call, and fetch the provenance schema and organ types once per process. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yuanzhou
approved these changes
Oct 27, 2026
yuanzhou
left a comment
yuanzhou
left a comment
Member
There was a problem hiding this comment.
@NickAkhmetov Thanks for discovering these issues and addressing them via this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.