feat(*): Remove legacy comparison views code #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test coverage
|
grafakus
commented
Aug 28, 2024
src/pages/ProfilesExplorerView/domain/variables/ServiceNameVariable/ServiceNameVariable.tsx
Show resolved
Hide resolved
grafakus
commented
Aug 28, 2024
grafakus
changed the title
grafakus
commented
Aug 28, 2024
bryanhuhta
previously approved these changes
Aug 28, 2024
# Conflicts: # e2e/fixtures/pages/ExploreProfilesPage.ts # e2e/fixtures/pages/PyroscopePage.ts # e2e/tests/comparison-diff-view/comparison-diff-view.spec.ts # e2e/tests/comparison-view/comparison-view-query-analysis.spec.ts # e2e/tests/comparison-view/comparison-view.spec.ts # e2e/tests/settings-view.spec.ts # src/pages/ComparisonView/components/ComparisonDiffPanel/ComparisonDiffPanel.tsx # src/pages/ProfilesExplorerView/domain/variables/ServiceNameVariable/ServiceNameVariable.tsx
grafakus
commented
Sep 16, 2024
grafakus
commented
Sep 16, 2024
grafakus
commented
Sep 16, 2024
...ponents/SceneFunctionDetailsPanel/components/CodeContainer/infrastructure/useFetchVCSFile.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # scripts/upgrade-playwright
# Conflicts: # e2e/tests/settings-view/settings-view.spec.ts-snapshots/Plugin-Settings-Flame-graph-settings-Can-be-modified-for-the-Flame-graph-views-1-chromium-linux.png # e2e/tests/settings-view/settings-view.spec.ts-snapshots/Plugin-Settings-Flame-graph-settings-Can-be-modified-for-the-Flame-graph-views-2-chromium-linux.png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Related issue(s): is a follow-up of #119, is blocked by #164
Now that the comparison view has been migrated to Scenes, we can delete the corresponding code.
📖 Summary of the changes
Deleting code! 🥳🥳
🧪 How to test?