Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): Remove legacy comparison views code #143

Merged
merged 16 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 0 additions & 76 deletions e2e/fixtures/components/Toolbar.ts

This file was deleted.

23 changes: 1 addition & 22 deletions e2e/fixtures/index.ts
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
import { test as base, expect } from '@playwright/test';

import { DEFAULT_EXPLORE_PROFILES_URL_PARAMS, DEFAULT_URL_PARAMS } from '../config/constants';
import { Toolbar } from './components/Toolbar';
import { DEFAULT_EXPLORE_PROFILES_URL_PARAMS } from '../config/constants';
import { AdHocViewPage } from './pages/AdHocViewPage';
import { ComparisonDiffViewPage } from './pages/ComparisonDiffViewPage';
import { ComparisonViewPage } from './pages/ComparisonViewPage';
import { ExploreProfilesPage } from './pages/ExploreProfilesPage';
import { SettingsPage } from './pages/SettingsPage';

type Fixtures = {
toolbar: Toolbar;
exploreProfilesPage: ExploreProfilesPage;
comparisonViewPage: ComparisonViewPage;
comparisonDiffViewPage: ComparisonDiffViewPage;
adHocViewPage: AdHocViewPage;
settingsPage: SettingsPage;
};
Expand Down Expand Up @@ -40,27 +34,12 @@ const withExceptionsAssertion = async ({ page, failOnUncaughtExceptions, use },
export const test = base.extend<Options & Fixtures>({
// fixture option accessible in every test case or fixture (default value = false)
failOnUncaughtExceptions: [false, { option: true }],
toolbar: async ({ page }, use) => {
await use(new Toolbar(page));
},
exploreProfilesPage: async ({ page, failOnUncaughtExceptions }, use) => {
await withExceptionsAssertion(
{ page, failOnUncaughtExceptions, use },
new ExploreProfilesPage(page, DEFAULT_EXPLORE_PROFILES_URL_PARAMS)
);
},
comparisonViewPage: async ({ page, failOnUncaughtExceptions }, use) => {
await withExceptionsAssertion(
{ page, failOnUncaughtExceptions, use },
new ComparisonViewPage(page, DEFAULT_URL_PARAMS)
);
},
comparisonDiffViewPage: async ({ page, failOnUncaughtExceptions }, use) => {
await withExceptionsAssertion(
{ page, failOnUncaughtExceptions, use },
new ComparisonDiffViewPage(page, DEFAULT_URL_PARAMS)
);
},
adHocViewPage: async ({ page, failOnUncaughtExceptions }, use) => {
await withExceptionsAssertion({ page, failOnUncaughtExceptions, use }, new AdHocViewPage(page));
},
Expand Down
72 changes: 0 additions & 72 deletions e2e/fixtures/pages/ComparisonDiffViewPage.ts

This file was deleted.

51 changes: 0 additions & 51 deletions e2e/fixtures/pages/ComparisonViewPage.ts

This file was deleted.

Loading
Loading